Re: [PATCH 1/1] Add lint-makefiles Makefile linting test.

[Florian Weimer <fweimer@redhat.com>]

* Alejandro Colomar:

> Hi Carlos,
>
> On 5/19/23 14:13, Carlos O'Donell via Libc-alpha wrote:
>> We add a `make check` test that lints all Makefiles in the source
>> directory of the glibc build. This linting test ensures that the
>> lines in all Makefiles will be sorted correctly as developers
>> creates patches.
>
> make check is usually to test the result of a build, according the
> GNU guidelines in:
>
> <https://www.gnu.org/software/make/manual/html_node/Standard-Targets.html>
>
> I believe linting the source code is a different thing, and so I
> used a different target in the Linux man-pages Makefile: 'lint'.
>
> So, in the man-pages project, it goes like this:
>
> lint -> build -> check -> install
>
> Maybe you could follow a similar scheme?  Otherwise, it's a bit
> weird to run the linters _after_ building (since `make check`
> requires previously building).

I think the consistency with the existing tests is more important.  The
way Carlos implemented it, it becomes part of developer workflows
automatically.

Thanks,
Florian