Re: [PATCH] Fix elf/loadfail test build dependencies

[Carlos O'Donell <carlos@redhat.com>]

On 1/28/22 08:36, Szabolcs Nagy via Libc-alpha wrote:
> There was no direct or indirect make dependency on testobj3.so so the
> test could fail with
> 
> /B/elf/loadfail: failed to load shared object: testobj3.so: cannot open
>  shared object file: No such file or directory

Good catch. OK for glibc 2.35.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

> ---
>  elf/Makefile | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/elf/Makefile b/elf/Makefile
> index 718e826290..1fa1a519a5 100644
> --- a/elf/Makefile
> +++ b/elf/Makefile
> @@ -1468,7 +1468,9 @@ preloadtest-ENV = \
>  
>  LDFLAGS-loadfail = -rdynamic
>  
> -$(objpfx)loadfail.out: $(objpfx)failobj.so
> +$(objpfx)loadfail.out: $(objpfx)failobj.so $(objpfx)testobj1.so \
> +		       $(objpfx)testobj2.so $(objpfx)testobj3.so \
> +		       $(objpfx)testobj4.so $(objpfx)testobj5.so
>  
>  LDFLAGS-multiload = -rdynamic
>  CFLAGS-multiload.c += -DOBJDIR=\"$(elf-objpfx)\"


-- 
Cheers,
Carlos.