From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH v3] nptl: Deallocate the thread stack on setup failure (BZ #19511)
Date: Wed, 2 Jun 2021 11:01:27 -0300 [thread overview]
Message-ID: <28311d99-55b0-808f-5130-1a9895b9cf77@linaro.org> (raw)
In-Reply-To: <87mts8jsda.fsf@igel.home>
On 02/06/2021 10:41, Andreas Schwab wrote:
> On Jun 02 2021, Adhemerval Zanella wrote:
>
>> On 02/06/2021 10:08, Andreas Schwab wrote:
>>> On Jun 02 2021, Adhemerval Zanella via Libc-alpha wrote:
>>>
>>>> diff --git a/nptl/descr.h b/nptl/descr.h
>>>> index 3de9535449..9d8297b45f 100644
>>>> --- a/nptl/descr.h
>>>> +++ b/nptl/descr.h
>>>> @@ -340,8 +340,9 @@ struct pthread
>>>> /* True if thread must stop at startup time. */
>>>> bool stopped_start;
>>>>
>>>> - /* Formerly used for dealing with cancellation. */
>>>> - int parent_cancelhandling_unsed;
>>>> + /* Indicate that a thread creation setup has failed (for instance the
>>>> + scheduler or affinity). */
>>>> + int setup_failed;
>>>
>>> Perhaps this should be turned into a bitfield?
>>
>> I do not want to change the 'struct parent' layout or size with this
>> patch.
>
> I didn't say you should change the layout.
I don't have a strong preference here, maybe use a 'bool' then?
next prev parent reply other threads:[~2021-06-02 14:01 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 17:28 [PATCH v2 0/9] nptl: pthread cancellation refactor Adhemerval Zanella
2021-05-27 17:28 ` [PATCH v2 1/9] nptl: Remove exit-thread.h Adhemerval Zanella
2021-06-01 7:51 ` Florian Weimer
2021-06-01 12:55 ` Adhemerval Zanella
2021-05-27 17:28 ` [PATCH v2 2/9] nptl: Deallocate the thread stack on setup failure (BZ #19511) Adhemerval Zanella
2021-06-01 8:32 ` Florian Weimer
2021-06-01 13:08 ` Adhemerval Zanella
2021-06-01 13:55 ` Adhemerval Zanella
2021-06-02 12:56 ` [PATCH v3] " Adhemerval Zanella
2021-06-02 13:08 ` Andreas Schwab
2021-06-02 13:39 ` Adhemerval Zanella
2021-06-02 13:41 ` Andreas Schwab
2021-06-02 14:01 ` Adhemerval Zanella [this message]
2021-06-02 14:07 ` Andreas Schwab
2021-06-02 14:15 ` Adhemerval Zanella
2021-06-02 14:30 ` Andreas Schwab
2021-06-02 14:42 ` Adhemerval Zanella
2021-06-02 18:20 ` Joseph Myers
2021-06-02 18:30 ` Florian Weimer
2021-06-02 19:02 ` Adhemerval Zanella
2021-06-02 19:11 ` Florian Weimer
2021-06-08 10:56 ` Florian Weimer
2021-06-08 17:01 ` Adhemerval Zanella
2021-06-09 13:49 ` Florian Weimer
2021-06-09 17:07 ` Adhemerval Zanella
2021-05-27 17:28 ` [PATCH v2 3/9] nptl: Install cancellation handler on pthread_cancel Adhemerval Zanella
2021-05-31 18:18 ` Adhemerval Zanella
2021-06-01 8:38 ` Florian Weimer
2021-06-01 13:10 ` Adhemerval Zanella
2021-06-01 8:39 ` Florian Weimer
2021-05-27 17:28 ` [PATCH v2 4/9] nptl: Remove CANCELING_BITMASK Adhemerval Zanella
2021-06-01 9:03 ` Florian Weimer
2021-06-01 13:50 ` Adhemerval Zanella
2021-06-01 16:36 ` Adhemerval Zanella
2021-05-27 17:28 ` [PATCH v2 5/9] nptl: Move cancel state out of cancelhandling Adhemerval Zanella
2021-06-01 9:58 ` Florian Weimer
2021-06-02 13:09 ` Adhemerval Zanella
2021-05-27 17:28 ` [PATCH v2 6/9] nptl: Move cancel type " Adhemerval Zanella
2021-06-01 12:37 ` Florian Weimer
2021-06-02 13:11 ` Adhemerval Zanella
2021-06-09 17:06 ` Adhemerval Zanella
2021-05-27 17:28 ` [PATCH v2 7/9] nptl: Implement raise in terms of pthread_kill Adhemerval Zanella
2021-06-01 12:40 ` Florian Weimer
2021-06-02 13:14 ` Adhemerval Zanella
2021-05-27 17:28 ` [PATCH v2 8/9] nptl: Use pthread_kill on pthread_cancel Adhemerval Zanella
2021-06-01 12:41 ` Florian Weimer
2021-05-27 17:28 ` [PATCH v2 9/9] nptl: Avoid async cancellation to wrongly update __nptl_nthreads (BZ #19366) Adhemerval Zanella
2021-06-01 14:29 ` Florian Weimer
2021-06-02 13:15 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28311d99-55b0-808f-5130-1a9895b9cf77@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).