Re: [PATCH] tests/string: Drop simple/stupid/builtin tests

[Siddhesh Poyarekar <siddhesh@sourceware.org>]

On 06/04/2022 01:58, Noah Goldstein wrote:
> On Tue, Apr 5, 2022 at 12:05 AM Siddhesh Poyarekar via Libc-alpha
> <libc-alpha@sourceware.org> wrote:
>>
>> In most cases the simple/stupid/builtin functions were in there to
>> benchmark optimized implementations against.  Only in some cases the
>> functions are used to check expected results.
>>
>> Remove these tests from IMPL() and only keep them in wherever they're
>> used for a specific purpose, e.g. to generate expected results.
>>
>> This improves timing of `make subdirs=string` by over a minute and a
>> half (over 15%) on a Whiskey Lake laptop.
> 
> Makes sense, although I would prefer if we kept the simple* functions
> and just removed them from the test list.
> 
> When adding new tests it's nice to have a guaranteed reference
> to test the test...
> 
> What do you think?

I don't feel too strongly either way, I'll send v2 with in-test variants 
retained where none exists so that they may be used in future if need 
arises.

Thanks,
Siddhesh