From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: Naohiro Tamura <naohirot@fujitsu.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH v3 4/5] benchtests: Fix validate_benchout.py exceptions
Date: Mon, 13 Sep 2021 09:20:04 +0530 [thread overview]
Message-ID: <2f0293c7-d0b2-0a3b-1ff9-48127837d3c5@gotplt.org> (raw)
In-Reply-To: <fcabec6f-75e8-89ce-1875-9e93c038e36f@gotplt.org>
On 9/13/21 9:12 AM, Siddhesh Poyarekar wrote:
>> --- a/benchtests/scripts/import_bench.py
>> +++ b/benchtests/scripts/import_bench.py
>> @@ -104,7 +104,10 @@ def do_for_all_timings(bench, callback):
>> """
>> for func in bench['functions'].keys():
>> for k in bench['functions'][func].keys():
>> - if 'timings' not in bench['functions'][func][k].keys():
>> + try:
>> + if 'timings' not in bench['functions'][func][k].keys():
>> + continue
>> + except AttributeError:
>> continue
>
> When do you get an AttributeError here?
>
OK the one possibility I can think of is when
bench['functions'][func][k] is None. This implies the existence of a
benchmark output that has a function variant without any inputs and
hence, without any benchmark data. That should be invalid, in which
case the benchmark should be fixed, not the validator.
Thanks,
Siddhesh
next prev parent reply other threads:[~2021-09-13 3:50 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 8:22 [PATCH] benchtests: Add memset zero fill benchmark tests Naohiro Tamura
2021-07-13 13:50 ` Lucas A. M. Magalhaes
2021-07-20 6:31 ` [PATCH v2 0/5] " Naohiro Tamura
2021-08-05 7:47 ` [PATCH v3 0/5] benchtests: Add memset zero fill benchmark test Naohiro Tamura
2021-08-05 7:49 ` [PATCH v3 1/5] benchtests: Enable scripts/plot_strings.py to read stdin Naohiro Tamura
2021-08-05 7:56 ` Siddhesh Poyarekar
2021-09-08 1:46 ` naohirot
2021-09-08 12:56 ` Siddhesh Poyarekar
2021-09-09 0:22 ` naohirot
2021-09-13 3:45 ` Siddhesh Poyarekar
2021-08-05 7:50 ` [PATCH v3 2/5] benchtests: Add memset zero fill benchtest Naohiro Tamura
2021-09-08 2:03 ` naohirot
2021-09-10 20:40 ` Lucas A. M. Magalhaes
2021-09-13 0:53 ` naohirot
2021-09-13 14:05 ` Lucas A. M. Magalhaes
2021-09-14 0:38 ` [PATCH v4] " Naohiro Tamura
2021-09-14 0:44 ` [PATCH v3 2/5] " naohirot
2021-09-14 14:02 ` Wilco Dijkstra
2021-09-15 8:24 ` naohirot
2021-09-21 1:27 ` naohirot
2021-09-21 11:09 ` Wilco Dijkstra
2021-09-22 1:05 ` [PATCH v5] " Naohiro Tamura
2023-02-09 17:23 ` Carlos O'Donell
2023-02-10 1:26 ` Siddhesh Poyarekar
2021-09-22 1:07 ` [PATCH v3 2/5] " naohirot
2021-09-28 1:40 ` naohirot
2021-09-30 0:55 ` Tamura, Naohiro/田村 直�
2021-10-18 12:57 ` Lucas A. M. Magalhaes
2021-10-20 13:44 ` Wilco Dijkstra
2021-10-20 15:35 ` Lucas A. M. Magalhaes
2021-10-20 17:47 ` Wilco Dijkstra
2021-10-22 13:08 ` Lucas A. M. Magalhaes
2021-08-05 7:51 ` [PATCH v3 3/5] benchtests: Remove redundant assert.h Naohiro Tamura
2021-09-08 1:59 ` naohirot
2021-09-13 3:36 ` Siddhesh Poyarekar
2021-08-05 7:51 ` [PATCH v3 4/5] benchtests: Fix validate_benchout.py exceptions Naohiro Tamura
2021-09-08 1:55 ` naohirot
2021-09-13 3:42 ` Siddhesh Poyarekar
2021-09-13 3:50 ` Siddhesh Poyarekar [this message]
2021-09-13 13:44 ` [PATCH v4] " Naohiro Tamura
2021-09-15 3:23 ` Siddhesh Poyarekar
2021-09-16 1:12 ` naohirot
2021-09-16 1:41 ` Siddhesh Poyarekar
2021-09-16 2:23 ` [PATCH v5] " Naohiro Tamura
2021-09-16 3:48 ` Siddhesh Poyarekar
2021-09-16 5:23 ` naohirot
2021-09-16 2:26 ` [PATCH v4] " naohirot
2021-09-13 13:46 ` [PATCH v3 4/5] " naohirot
2021-08-05 7:52 ` [PATCH v3 5/5] config: Rename HAVE_BUILTIN_MEMSET macro Naohiro Tamura
2021-08-11 20:34 ` Adhemerval Zanella
2021-07-20 6:34 ` [PATCH v2 1/5] benchtests: Enable scripts/plot_strings.py to read stdin Naohiro Tamura
2021-07-20 6:35 ` [PATCH v2 2/5] benchtests: Add memset zero fill benchtest Naohiro Tamura
2021-07-20 16:48 ` Noah Goldstein
2021-07-21 12:56 ` naohirot
2021-07-21 13:07 ` naohirot
2021-07-21 18:14 ` Noah Goldstein
2021-07-21 19:17 ` Wilco Dijkstra
2021-07-26 8:42 ` naohirot
2021-07-26 11:15 ` Wilco Dijkstra
2021-07-27 2:24 ` naohirot
2021-07-27 17:26 ` Wilco Dijkstra
2021-07-28 7:27 ` naohirot
2021-08-04 9:11 ` naohirot
2021-07-26 8:39 ` naohirot
2021-07-26 17:22 ` Noah Goldstein
2021-07-20 6:35 ` [PATCH v2 3/5] benchtests: Add a script to convert benchout string JSON to CSV Naohiro Tamura
2021-07-21 2:41 ` naohirot
2021-07-27 20:17 ` Joseph Myers
2021-07-29 1:56 ` naohirot
2021-07-29 4:42 ` Siddhesh Poyarekar
2021-07-30 7:05 ` naohirot
2021-07-31 10:47 ` Siddhesh Poyarekar
2021-07-20 6:36 ` [PATCH v2 4/5] benchtests: Remove redundant assert.h Naohiro Tamura
2021-07-20 6:37 ` [PATCH v2 5/5] benchtests: Fix validate_benchout.py exceptions Naohiro Tamura
2021-07-26 8:34 ` [PATCH] config: Remove HAVE_BUILTIN_MEMSET macro Naohiro Tamura
2021-07-26 8:48 ` naohirot
2021-07-26 8:49 ` Andreas Schwab
2021-07-26 9:42 ` naohirot
2021-07-26 9:51 ` Andreas Schwab
2021-07-26 13:16 ` naohirot
2021-07-26 8:35 ` [PATCH] benchtests: Add a script to merge two benchout string files Naohiro Tamura
2021-07-27 20:51 ` Joseph Myers
2021-07-30 7:04 ` naohirot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f0293c7-d0b2-0a3b-1ff9-48127837d3c5@gotplt.org \
--to=siddhesh@gotplt.org \
--cc=libc-alpha@sourceware.org \
--cc=naohirot@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).