public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "naohirot@fujitsu.com" <naohirot@fujitsu.com>
To: 'Siddhesh Poyarekar' <siddhesh@gotplt.org>,
	'Joseph Myers' <joseph@codesourcery.com>
Cc: "libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
	Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Subject: RE: [PATCH v2 3/5] benchtests: Add a script to convert benchout string JSON to CSV
Date: Fri, 30 Jul 2021 07:05:10 +0000	[thread overview]
Message-ID: <TYAPR01MB6025DF2CD7E90AA4FF286508DFEC9@TYAPR01MB6025.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <d619b667-88d2-593d-cb81-3fb604d37885@gotplt.org>

Hi Siddhesh,

Thank you for the advice!

> Most people in the community who work in string function improvements
> tend to use (and improve wherever it is lacking)
> benchtests/scripts/compare_strings.py for their result analysis.  Adding
> a flag to dump csv to that script ought to be trivial if that's what you
> need.

I see. I didn't use compare_strings.py daily, but plot_strings.py.

> The script is under-documented though, so perhaps a wiki page describing
> what the script does and various example uses would go a very long way.

I found the wiki page.
https://sourceware.org/glibc/wiki/benchmarking/benchmarks

> The reason for emitting json is precisely to allow developers to
> implement their own analysis tools around them when their use cases are
> niche.  Your specific use case is not niche and could be added as a flag
> to compare_strings.py if needed.  You only need a new flag --csv (or -o
> csv, tab, etc.) to print in csv instead of the current output, which is
> meant for reading on the terminal.

Yes, converting to CSV in Python will be easy.
But comparing two string benchout results directly between "before" and "after"
was not so easy AFAIK. 
And creating graphs in spreadsheet manually is tolerable in a few times, but not
in frequent times.
That's the reason I created another 'jq' script, merge_strings4graph.sh".
Dose most people compare the two results indirectly through a common base ifunc
using "--base" option of compare_strings.py or "--baseline" option of plot_strings.py?

Thanks.
Naohiro


  reply	other threads:[~2021-07-30  7:05 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13  8:22 [PATCH] benchtests: Add memset zero fill benchmark tests Naohiro Tamura
2021-07-13 13:50 ` Lucas A. M. Magalhaes
2021-07-20  6:31 ` [PATCH v2 0/5] " Naohiro Tamura
2021-08-05  7:47   ` [PATCH v3 0/5] benchtests: Add memset zero fill benchmark test Naohiro Tamura
2021-08-05  7:49     ` [PATCH v3 1/5] benchtests: Enable scripts/plot_strings.py to read stdin Naohiro Tamura
2021-08-05  7:56       ` Siddhesh Poyarekar
2021-09-08  1:46         ` naohirot
2021-09-08 12:56           ` Siddhesh Poyarekar
2021-09-09  0:22             ` naohirot
2021-09-13  3:45               ` Siddhesh Poyarekar
2021-08-05  7:50     ` [PATCH v3 2/5] benchtests: Add memset zero fill benchtest Naohiro Tamura
2021-09-08  2:03       ` naohirot
2021-09-10 20:40       ` Lucas A. M. Magalhaes
2021-09-13  0:53         ` naohirot
2021-09-13 14:05           ` Lucas A. M. Magalhaes
2021-09-14  0:38             ` [PATCH v4] " Naohiro Tamura
2021-09-14  0:44             ` [PATCH v3 2/5] " naohirot
2021-09-14 14:02               ` Wilco Dijkstra
2021-09-15  8:24                 ` naohirot
2021-09-21  1:27                   ` naohirot
2021-09-21 11:09                     ` Wilco Dijkstra
2021-09-22  1:05                       ` [PATCH v5] " Naohiro Tamura
2023-02-09 17:23                         ` Carlos O'Donell
2023-02-10  1:26                           ` Siddhesh Poyarekar
2021-09-22  1:07                       ` [PATCH v3 2/5] " naohirot
2021-09-28  1:40                         ` naohirot
2021-09-30  0:55                           ` Tamura, Naohiro/田村 直�
2021-10-18 12:57                           ` Lucas A. M. Magalhaes
2021-10-20 13:44                             ` Wilco Dijkstra
2021-10-20 15:35                               ` Lucas A. M. Magalhaes
2021-10-20 17:47                                 ` Wilco Dijkstra
2021-10-22 13:08                                   ` Lucas A. M. Magalhaes
2021-08-05  7:51     ` [PATCH v3 3/5] benchtests: Remove redundant assert.h Naohiro Tamura
2021-09-08  1:59       ` naohirot
2021-09-13  3:36       ` Siddhesh Poyarekar
2021-08-05  7:51     ` [PATCH v3 4/5] benchtests: Fix validate_benchout.py exceptions Naohiro Tamura
2021-09-08  1:55       ` naohirot
2021-09-13  3:42       ` Siddhesh Poyarekar
2021-09-13  3:50         ` Siddhesh Poyarekar
2021-09-13 13:44           ` [PATCH v4] " Naohiro Tamura
2021-09-15  3:23             ` Siddhesh Poyarekar
2021-09-16  1:12               ` naohirot
2021-09-16  1:41                 ` Siddhesh Poyarekar
2021-09-16  2:23                   ` [PATCH v5] " Naohiro Tamura
2021-09-16  3:48                     ` Siddhesh Poyarekar
2021-09-16  5:23                       ` naohirot
2021-09-16  2:26                   ` [PATCH v4] " naohirot
2021-09-13 13:46           ` [PATCH v3 4/5] " naohirot
2021-08-05  7:52     ` [PATCH v3 5/5] config: Rename HAVE_BUILTIN_MEMSET macro Naohiro Tamura
2021-08-11 20:34       ` Adhemerval Zanella
2021-07-20  6:34 ` [PATCH v2 1/5] benchtests: Enable scripts/plot_strings.py to read stdin Naohiro Tamura
2021-07-20  6:35 ` [PATCH v2 2/5] benchtests: Add memset zero fill benchtest Naohiro Tamura
2021-07-20 16:48   ` Noah Goldstein
2021-07-21 12:56     ` naohirot
2021-07-21 13:07       ` naohirot
2021-07-21 18:14         ` Noah Goldstein
2021-07-21 19:17           ` Wilco Dijkstra
2021-07-26  8:42             ` naohirot
2021-07-26 11:15               ` Wilco Dijkstra
2021-07-27  2:24                 ` naohirot
2021-07-27 17:26                   ` Wilco Dijkstra
2021-07-28  7:27                     ` naohirot
2021-08-04  9:11                       ` naohirot
2021-07-26  8:39     ` naohirot
2021-07-26 17:22       ` Noah Goldstein
2021-07-20  6:35 ` [PATCH v2 3/5] benchtests: Add a script to convert benchout string JSON to CSV Naohiro Tamura
2021-07-21  2:41   ` naohirot
2021-07-27 20:17   ` Joseph Myers
2021-07-29  1:56     ` naohirot
2021-07-29  4:42       ` Siddhesh Poyarekar
2021-07-30  7:05         ` naohirot [this message]
2021-07-31 10:47           ` Siddhesh Poyarekar
2021-07-20  6:36 ` [PATCH v2 4/5] benchtests: Remove redundant assert.h Naohiro Tamura
2021-07-20  6:37 ` [PATCH v2 5/5] benchtests: Fix validate_benchout.py exceptions Naohiro Tamura
2021-07-26  8:34 ` [PATCH] config: Remove HAVE_BUILTIN_MEMSET macro Naohiro Tamura
2021-07-26  8:48   ` naohirot
2021-07-26  8:49   ` Andreas Schwab
2021-07-26  9:42     ` naohirot
2021-07-26  9:51       ` Andreas Schwab
2021-07-26 13:16         ` naohirot
2021-07-26  8:35 ` [PATCH] benchtests: Add a script to merge two benchout string files Naohiro Tamura
2021-07-27 20:51   ` Joseph Myers
2021-07-30  7:04     ` naohirot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYAPR01MB6025DF2CD7E90AA4FF286508DFEC9@TYAPR01MB6025.jpnprd01.prod.outlook.com \
    --to=naohirot@fujitsu.com \
    --cc=Wilco.Dijkstra@arm.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=siddhesh@gotplt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).