From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Florian Weimer <fw@deneb.enyo.de>
Cc: Yu Chien Peter Lin <peterlin@andestech.com>,
libc-alpha@sourceware.org, ycliang@andestech.com,
dylan@andestech.com, alankao@andestech.com
Subject: Re: [PATCH v2] malloc: Fix clobbered errno when getrandom failed [BZ #29624]
Date: Thu, 29 Sep 2022 10:51:49 -0300 [thread overview]
Message-ID: <313bf716-fe53-c3cb-f30b-26c38e6341b2@linaro.org> (raw)
In-Reply-To: <875yh671eq.fsf@mid.deneb.enyo.de>
On 29/09/22 10:31, Florian Weimer wrote:
> * Adhemerval Zanella Netto:
>
>> diff --git a/sysdeps/unix/sysv/linux/not-cancel.h b/sysdeps/unix/sysv/linux/not-cancel.h
>> index a263d294b1..00ab75a405 100644
>> --- a/sysdeps/unix/sysv/linux/not-cancel.h
>> +++ b/sysdeps/unix/sysv/linux/not-cancel.h
>> @@ -71,7 +71,7 @@ __writev_nocancel_nostatus (int fd, const struct iovec *iov, int iovcnt)
>> static inline int
>> __getrandom_nocancel (void *buf, size_t buflen, unsigned int flags)
>> {
>> - return INLINE_SYSCALL_CALL (getrandom, buf, buflen, flags);
>> + return INTERNAL_SYSCALL_CALL (getrandom, buf, buflen, flags);
>> }
>>
>> static inline int
>
> Doesn't this need a matching change to sysdeps/mach/hurd/not-cancel.h?
Yeah, it will to make __arc4random_buf use the /dev/random fallback.
prev parent reply other threads:[~2022-09-29 13:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 11:13 Yu Chien Peter Lin
2022-09-29 11:39 ` Adhemerval Zanella Netto
2022-09-29 13:31 ` Florian Weimer
2022-09-29 13:51 ` Adhemerval Zanella Netto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=313bf716-fe53-c3cb-f30b-26c38e6341b2@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=alankao@andestech.com \
--cc=dylan@andestech.com \
--cc=fw@deneb.enyo.de \
--cc=libc-alpha@sourceware.org \
--cc=peterlin@andestech.com \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).