From: Carlos O'Donell <carlos@redhat.com>
To: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH v3 0/6] Remaining librt to libc moves
Date: Sun, 27 Jun 2021 17:39:57 -0400 [thread overview]
Message-ID: <31dcea10-592a-bbae-2254-7fb0f071bccd@redhat.com> (raw)
In-Reply-To: <cover.1624620992.git.fweimer@redhat.com>
On 6/25/21 7:41 AM, Florian Weimer via Libc-alpha wrote:
> This patch reposts the remaining patches, starting at the first
> unreviewed patch. I followed Adhemerval's suggestions.
>
> Tested on i686-linux-gnu and x86_64-linux-gnu. Built with
> build-many-glibcs.py.
I'm using Reviewed-by to drive a tactical review of this series
(patchwork helps me track this, thanks for including the RB's).
Patch 1 and 6 need review. I'm reviewing those. With my review
that completes a full review of the whole series.
Patches 2, 3, 4, and 5 are reviewed by Adhemerval.
Overall the series looks good to me, and I know the lack of int
to timer_t transition on mips64/n64 caused a hiccup, which involves
making a decision on patch 1 to add some kind of change that
captures that in a clean way. Patch 1 achieves that goal.
> Thanks,
> Florian
>
> Florian Weimer (6):
> Linux: Define TIMER_T_WAS_INT_COMPAT in kernel-posix-timers.h
> Linux: Move timer_create, timer_delete from librt to libc
> Linux: Move timer_getoverrun from librt to libc
> Linux: Move timer_gettime, __timer_gettime64 from librt to libc
> Linux: Move timer_settime, __timer_settime64 from librt to libc
> Linux: Cleanups after librt move
>
> elf/Makefile | 4 +-
> include/time.h | 12 ++-
> misc/Makefile | 6 --
> nptl/Makefile | 9 ---
> rt/Makefile | 23 ++++--
> rt/Versions | 47 ++++++------
> rt/aio_misc.c | 14 ----
> rt/aio_notify.c | 8 --
> rt/aio_sigqueue.c | 1 -
> rt/librt-compat.c | 16 ++--
> sysdeps/generic/aio_misc.h | 43 +++--------
> sysdeps/htl/Makeconfig | 6 ++
> sysdeps/nptl/Makeconfig | 1 +
> sysdeps/pthread/Makefile | 14 +---
> sysdeps/unix/sysv/linux/Makefile | 13 ----
> sysdeps/unix/sysv/linux/Versions | 33 +++++----
> sysdeps/unix/sysv/linux/aarch64/libc.abilist | 10 +++
> sysdeps/unix/sysv/linux/aarch64/librt.abilist | 6 +-
> sysdeps/unix/sysv/linux/aio_sigqueue.c | 1 -
> sysdeps/unix/sysv/linux/alpha/Versions | 5 --
> sysdeps/unix/sysv/linux/alpha/libc.abilist | 15 ++++
> sysdeps/unix/sysv/linux/alpha/librt-compat.c | 2 +-
> sysdeps/unix/sysv/linux/alpha/librt.abilist | 12 +--
> sysdeps/unix/sysv/linux/alpha/timer_create.c | 1 -
> sysdeps/unix/sysv/linux/alpha/timer_delete.c | 1 -
> .../unix/sysv/linux/alpha/timer_getoverr.c | 1 -
> sysdeps/unix/sysv/linux/alpha/timer_gettime.c | 1 -
> sysdeps/unix/sysv/linux/alpha/timer_settime.c | 1 -
> .../sysv/linux/alpha/timer_t_was_int_compat.h | 19 +++++
> sysdeps/unix/sysv/linux/arc/libc.abilist | 10 +++
> sysdeps/unix/sysv/linux/arc/librt.abilist | 6 +-
> sysdeps/unix/sysv/linux/arm/be/libc.abilist | 12 +++
> sysdeps/unix/sysv/linux/arm/be/librt.abilist | 8 +-
> sysdeps/unix/sysv/linux/arm/le/libc.abilist | 12 +++
> sysdeps/unix/sysv/linux/arm/le/librt.abilist | 8 +-
> sysdeps/unix/sysv/linux/csky/libc.abilist | 12 +++
> sysdeps/unix/sysv/linux/csky/librt.abilist | 8 +-
> sysdeps/unix/sysv/linux/hppa/libc.abilist | 12 +++
> sysdeps/unix/sysv/linux/hppa/librt.abilist | 8 +-
> sysdeps/unix/sysv/linux/i386/libc.abilist | 12 +++
> sysdeps/unix/sysv/linux/i386/librt.abilist | 8 +-
> sysdeps/unix/sysv/linux/ia64/Versions | 7 --
> sysdeps/unix/sysv/linux/ia64/libc.abilist | 15 ++++
> sysdeps/unix/sysv/linux/ia64/librt.abilist | 12 +--
> sysdeps/unix/sysv/linux/ia64/timer_create.c | 1 -
> sysdeps/unix/sysv/linux/ia64/timer_delete.c | 1 -
> sysdeps/unix/sysv/linux/ia64/timer_getoverr.c | 1 -
> sysdeps/unix/sysv/linux/ia64/timer_gettime.c | 1 -
> sysdeps/unix/sysv/linux/ia64/timer_settime.c | 1 -
> .../sysv/linux/ia64/timer_t_was_int_compat.h | 19 +++++
> sysdeps/unix/sysv/linux/kernel-posix-timers.h | 32 +++++---
> sysdeps/unix/sysv/linux/librt-compat.c | 26 +++++++
> .../sysv/linux/m68k/coldfire/libc.abilist | 12 +++
> .../sysv/linux/m68k/coldfire/librt.abilist | 8 +-
> .../unix/sysv/linux/m68k/m680x0/libc.abilist | 12 +++
> .../unix/sysv/linux/m68k/m680x0/librt.abilist | 8 +-
> .../sysv/linux/microblaze/be/libc.abilist | 12 +++
> .../sysv/linux/microblaze/be/librt.abilist | 8 +-
> .../sysv/linux/microblaze/le/libc.abilist | 12 +++
> .../sysv/linux/microblaze/le/librt.abilist | 8 +-
> .../sysv/linux/mips/mips32/fpu/libc.abilist | 12 +++
> .../unix/sysv/linux/mips/mips32/librt.abilist | 8 +-
> .../sysv/linux/mips/mips32/nofpu/libc.abilist | 12 +++
> .../sysv/linux/mips/mips64/n32/libc.abilist | 12 +++
> .../sysv/linux/mips/mips64/n32/librt.abilist | 8 +-
> .../sysv/linux/mips/mips64/n64/libc.abilist | 10 +++
> .../sysv/linux/mips/mips64/n64/librt.abilist | 6 +-
> sysdeps/unix/sysv/linux/nios2/libc.abilist | 12 +++
> sysdeps/unix/sysv/linux/nios2/librt.abilist | 8 +-
> .../linux/powerpc/powerpc32/fpu/libc.abilist | 12 +++
> .../linux/powerpc/powerpc32/librt.abilist | 8 +-
> .../powerpc/powerpc32/nofpu/libc.abilist | 12 +++
> .../sysv/linux/powerpc/powerpc64/Versions | 8 --
> .../linux/powerpc/powerpc64/be/libc.abilist | 15 ++++
> .../linux/powerpc/powerpc64/be/librt.abilist | 12 +--
> .../linux/powerpc/powerpc64/le/libc.abilist | 10 +++
> .../linux/powerpc/powerpc64/le/librt.abilist | 6 +-
> .../linux/powerpc/powerpc64/timer_create.c | 1 -
> .../linux/powerpc/powerpc64/timer_delete.c | 1 -
> .../linux/powerpc/powerpc64/timer_getoverr.c | 1 -
> .../linux/powerpc/powerpc64/timer_gettime.c | 1 -
> .../linux/powerpc/powerpc64/timer_settime.c | 1 -
> .../powerpc64/timer_t_was_int_compat.h | 19 +++++
> .../unix/sysv/linux/riscv/rv32/libc.abilist | 10 +++
> .../unix/sysv/linux/riscv/rv32/librt.abilist | 6 +-
> .../unix/sysv/linux/riscv/rv64/libc.abilist | 10 +++
> .../unix/sysv/linux/riscv/rv64/librt.abilist | 6 +-
> .../unix/sysv/linux/s390/s390-32/libc.abilist | 12 +++
> .../sysv/linux/s390/s390-32/librt.abilist | 8 +-
> sysdeps/unix/sysv/linux/s390/s390-64/Versions | 8 --
> .../unix/sysv/linux/s390/s390-64/libc.abilist | 15 ++++
> .../sysv/linux/s390/s390-64/librt.abilist | 12 +--
> .../sysv/linux/s390/s390-64/timer_create.c | 1 -
> .../sysv/linux/s390/s390-64/timer_delete.c | 1 -
> .../sysv/linux/s390/s390-64/timer_getoverr.c | 1 -
> .../sysv/linux/s390/s390-64/timer_gettime.c | 1 -
> .../sysv/linux/s390/s390-64/timer_settime.c | 1 -
> .../s390/s390-64/timer_t_was_int_compat.h | 19 +++++
> sysdeps/unix/sysv/linux/sh/be/libc.abilist | 12 +++
> sysdeps/unix/sysv/linux/sh/be/librt.abilist | 8 +-
> sysdeps/unix/sysv/linux/sh/le/libc.abilist | 12 +++
> sysdeps/unix/sysv/linux/sh/le/librt.abilist | 8 +-
> sysdeps/unix/sysv/linux/sparc/librt-compat.c | 2 +-
> .../sysv/linux/sparc/sparc32/libc.abilist | 12 +++
> .../sysv/linux/sparc/sparc32/librt.abilist | 8 +-
> .../unix/sysv/linux/sparc/sparc64/Versions | 8 --
> .../sysv/linux/sparc/sparc64/libc.abilist | 15 ++++
> .../sysv/linux/sparc/sparc64/librt.abilist | 12 +--
> .../sysv/linux/sparc/sparc64/timer_create.c | 1 -
> .../sysv/linux/sparc/sparc64/timer_delete.c | 1 -
> .../sysv/linux/sparc/sparc64/timer_getoverr.c | 1 -
> .../sysv/linux/sparc/sparc64/timer_gettime.c | 1 -
> .../sysv/linux/sparc/sparc64/timer_settime.c | 1 -
> .../sparc/sparc64/timer_t_was_int_compat.h | 19 +++++
> sysdeps/unix/sysv/linux/timer_create.c | 68 +++++++++++++----
> sysdeps/unix/sysv/linux/timer_delete.c | 46 +++++++++---
> sysdeps/unix/sysv/linux/timer_getoverr.c | 32 ++++++--
> sysdeps/unix/sysv/linux/timer_gettime.c | 63 +++++++++++++---
> sysdeps/unix/sysv/linux/timer_routines.c | 10 +--
> sysdeps/unix/sysv/linux/timer_settime.c | 73 +++++++++++++++----
> ...er_getoverr.c => timer_t_was_int_compat.h} | 26 +------
> .../unix/sysv/linux/x86_64/64/libc.abilist | 15 ++++
> .../unix/sysv/linux/x86_64/64/librt.abilist | 12 +--
> .../linux/x86_64/64/timer_t_was_int_compat.h | 19 +++++
> sysdeps/unix/sysv/linux/x86_64/Versions | 8 --
> sysdeps/unix/sysv/linux/x86_64/compat-timer.h | 45 ------------
> sysdeps/unix/sysv/linux/x86_64/timer_create.c | 65 -----------------
> sysdeps/unix/sysv/linux/x86_64/timer_delete.c | 44 -----------
> .../unix/sysv/linux/x86_64/timer_gettime.c | 41 -----------
> .../unix/sysv/linux/x86_64/timer_settime.c | 44 -----------
> .../unix/sysv/linux/x86_64/x32/libc.abilist | 10 +++
> .../unix/sysv/linux/x86_64/x32/librt.abilist | 6 +-
> sysvipc/Makefile | 6 --
> time/Makefile | 6 --
> 134 files changed, 924 insertions(+), 779 deletions(-)
> delete mode 100644 sysdeps/unix/sysv/linux/alpha/timer_create.c
> delete mode 100644 sysdeps/unix/sysv/linux/alpha/timer_delete.c
> delete mode 100644 sysdeps/unix/sysv/linux/alpha/timer_getoverr.c
> delete mode 100644 sysdeps/unix/sysv/linux/alpha/timer_gettime.c
> delete mode 100644 sysdeps/unix/sysv/linux/alpha/timer_settime.c
> create mode 100644 sysdeps/unix/sysv/linux/alpha/timer_t_was_int_compat.h
> delete mode 100644 sysdeps/unix/sysv/linux/ia64/timer_create.c
> delete mode 100644 sysdeps/unix/sysv/linux/ia64/timer_delete.c
> delete mode 100644 sysdeps/unix/sysv/linux/ia64/timer_getoverr.c
> delete mode 100644 sysdeps/unix/sysv/linux/ia64/timer_gettime.c
> delete mode 100644 sysdeps/unix/sysv/linux/ia64/timer_settime.c
> create mode 100644 sysdeps/unix/sysv/linux/ia64/timer_t_was_int_compat.h
> create mode 100644 sysdeps/unix/sysv/linux/librt-compat.c
> delete mode 100644 sysdeps/unix/sysv/linux/powerpc/powerpc64/timer_create.c
> delete mode 100644 sysdeps/unix/sysv/linux/powerpc/powerpc64/timer_delete.c
> delete mode 100644 sysdeps/unix/sysv/linux/powerpc/powerpc64/timer_getoverr.c
> delete mode 100644 sysdeps/unix/sysv/linux/powerpc/powerpc64/timer_gettime.c
> delete mode 100644 sysdeps/unix/sysv/linux/powerpc/powerpc64/timer_settime.c
> create mode 100644 sysdeps/unix/sysv/linux/powerpc/powerpc64/timer_t_was_int_compat.h
> delete mode 100644 sysdeps/unix/sysv/linux/s390/s390-64/timer_create.c
> delete mode 100644 sysdeps/unix/sysv/linux/s390/s390-64/timer_delete.c
> delete mode 100644 sysdeps/unix/sysv/linux/s390/s390-64/timer_getoverr.c
> delete mode 100644 sysdeps/unix/sysv/linux/s390/s390-64/timer_gettime.c
> delete mode 100644 sysdeps/unix/sysv/linux/s390/s390-64/timer_settime.c
> create mode 100644 sysdeps/unix/sysv/linux/s390/s390-64/timer_t_was_int_compat.h
> delete mode 100644 sysdeps/unix/sysv/linux/sparc/sparc64/timer_create.c
> delete mode 100644 sysdeps/unix/sysv/linux/sparc/sparc64/timer_delete.c
> delete mode 100644 sysdeps/unix/sysv/linux/sparc/sparc64/timer_getoverr.c
> delete mode 100644 sysdeps/unix/sysv/linux/sparc/sparc64/timer_gettime.c
> delete mode 100644 sysdeps/unix/sysv/linux/sparc/sparc64/timer_settime.c
> create mode 100644 sysdeps/unix/sysv/linux/sparc/sparc64/timer_t_was_int_compat.h
> rename sysdeps/unix/sysv/linux/{x86_64/timer_getoverr.c => timer_t_was_int_compat.h} (54%)
> create mode 100644 sysdeps/unix/sysv/linux/x86_64/64/timer_t_was_int_compat.h
> delete mode 100644 sysdeps/unix/sysv/linux/x86_64/compat-timer.h
> delete mode 100644 sysdeps/unix/sysv/linux/x86_64/timer_create.c
> delete mode 100644 sysdeps/unix/sysv/linux/x86_64/timer_delete.c
> delete mode 100644 sysdeps/unix/sysv/linux/x86_64/timer_gettime.c
> delete mode 100644 sysdeps/unix/sysv/linux/x86_64/timer_settime.c
>
--
Cheers,
Carlos.
prev parent reply other threads:[~2021-06-27 21:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 11:41 Florian Weimer
2021-06-25 11:41 ` [PATCH 1/6] Linux: Define TIMER_T_WAS_INT_COMPAT in kernel-posix-timers.h Florian Weimer
2021-06-27 21:38 ` Carlos O'Donell
2021-06-25 11:41 ` [PATCH 2/6] Linux: Move timer_create, timer_delete from librt to libc Florian Weimer
2021-06-25 11:42 ` [PATCH 3/6] Linux: Move timer_getoverrun " Florian Weimer
2021-06-25 11:42 ` [PATCH 4/6] Linux: Move timer_gettime, __timer_gettime64 " Florian Weimer
2021-06-25 11:42 ` [PATCH 5/6] Linux: Move timer_settime, __timer_settime64 " Florian Weimer
2021-06-25 11:42 ` [PATCH 6/6] Linux: Cleanups after librt move Florian Weimer
2021-06-27 21:39 ` Carlos O'Donell
2021-06-27 21:39 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31dcea10-592a-bbae-2254-7fb0f071bccd@redhat.com \
--to=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).