From: Carlos O'Donell <carlos@redhat.com>
To: Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com>,
libc-alpha@sourceware.org
Subject: Re: [PATCH] powerpc: Fix TOC stub on powerpc64 clone()
Date: Fri, 28 Oct 2016 11:58:00 -0000 [thread overview]
Message-ID: <32534ecf-02f1-c139-40f4-c18760e88398@redhat.com> (raw)
In-Reply-To: <1477083962-9894-1-git-send-email-tuliom@linux.vnet.ibm.com>
On 10/21/2016 05:06 PM, Tulio Magno Quites Machado Filho wrote:
> Use a function call to _exit() so that the linker can create a TOC stub
> instead of just a branch.
>
> 2016-10-21 Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com>
>
> [BZ #20728]
> * sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S: Replace a
> branch to _exit() by a function call.
> ---
> sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S b/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S
> index 7c59b9b..df824f5 100644
> --- a/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S
> +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S
> @@ -97,7 +97,7 @@ L(oldpid):
> #ifdef SHARED
> b JUMPTARGET(__GI__exit)
> #else
> - b JUMPTARGET(_exit)
> + bl JUMPTARGET(_exit)
> /* We won't ever get here but provide a nop so that the linker
> will insert a toc adjusting stub if necessary. */
> nop
I agree with Adhemerval that this _looks_ good, but you'd have to claim
it works _and_ review the final linked code generated by the static linker.
--
Cheers,
Carlos.
next prev parent reply other threads:[~2016-10-28 11:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 21:06 Tulio Magno Quites Machado Filho
2016-10-21 21:49 ` Adhemerval Zanella
2016-10-28 11:58 ` Carlos O'Donell [this message]
2016-10-28 20:17 ` Tulio Magno Quites Machado Filho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32534ecf-02f1-c139-40f4-c18760e88398@redhat.com \
--to=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=tuliom@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).