From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>,
Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] linux: Split tst-ttyname
Date: Mon, 5 Jun 2023 14:14:46 -0300 [thread overview]
Message-ID: <3d708678-6d74-b527-2e50-89255fcd65d1@linaro.org> (raw)
In-Reply-To: <87pm6ayqzq.fsf@oldenburg.str.redhat.com>
On 05/06/23 10:32, Florian Weimer wrote:
> * Adhemerval Zanella via Libc-alpha:
>
>> sysdeps/unix/sysv/linux/Makefile | 1 +
>> sysdeps/unix/sysv/linux/tst-ttyname-common.c | 416 ++++++++++++++
>> .../unix/sysv/linux/tst-ttyname-namespace.c | 147 +++++
>> sysdeps/unix/sysv/linux/tst-ttyname.c | 512 +-----------------
>> 4 files changed, 567 insertions(+), 509 deletions(-)
>> create mode 100644 sysdeps/unix/sysv/linux/tst-ttyname-common.c
>> create mode 100644 sysdeps/unix/sysv/linux/tst-ttyname-namespace.c
>
> I'd prefer if we could stop using the original tst-ttyname name for
> clarity.
Do you mean for the new tst-ttyname-namespace or for tst-ttyname as well?
The test idea is really to check ttyname, so what exactly do you suggest
us to change?
next prev parent reply other threads:[~2023-06-05 17:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 17:44 Adhemerval Zanella
2023-06-02 17:32 ` Xi Ruoyao
2023-06-03 2:11 ` Carlos O'Donell
2023-06-05 17:11 ` Adhemerval Zanella Netto
2023-06-05 13:32 ` Florian Weimer
2023-06-05 17:14 ` Adhemerval Zanella Netto [this message]
2023-06-05 18:20 ` Florian Weimer
2023-06-05 18:21 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d708678-6d74-b527-2e50-89255fcd65d1@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).