[PATCH] Exclude tst-realloc from tests-mcheck

[PATCH] Exclude tst-realloc from tests-mcheck

[Siddhesh Poyarekar]

The realloc (NULL, 0) test in tst-realloc fails with gcc 7.x but
passes with newer gcc.  This is because a newer gcc transforms the
realloc call to malloc (0), thus masking the bug in mcheck.

Disable the test with mcheck for now.  The malloc removal patchset
will fix this and then remove this test from the exclusion list.

I'll push this soon if there are no objections.  I'll also post an
updated malloc hooks patchset with these issues fixed.

Reported-by: Stefan Liebler <stli@linux.ibm.com>
---
 malloc/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/malloc/Makefile b/malloc/Makefile
index 2f9b3d596d..2af1203a0a 100644
--- a/malloc/Makefile
+++ b/malloc/Makefile
@@ -93,7 +93,8 @@ tests-exclude-mcheck = tst-mallocstate \
 	tst-malloc-usable-tunables \
 	tst-malloc_info \
 	tst-memalign \
-	tst-posix_memalign
+	tst-posix_memalign \
+	tst-posix-realloc
 
 tests-mcheck = $(filter-out $(tests-exclude-mcheck), $(tests))
 
-- 
2.31.1

Re: [PATCH] Exclude tst-realloc from tests-mcheck

[Siddhesh Poyarekar]

On 7/6/21 9:31 PM, Siddhesh Poyarekar via Libc-alpha wrote:
> The realloc (NULL, 0) test in tst-realloc fails with gcc 7.x but
> passes with newer gcc.  This is because a newer gcc transforms the
> realloc call to malloc (0), thus masking the bug in mcheck.
> 
> Disable the test with mcheck for now.  The malloc removal patchset
> will fix this and then remove this test from the exclusion list.
> 
> I'll push this soon if there are no objections.  I'll also post an
> updated malloc hooks patchset with these issues fixed.
> 
> Reported-by: Stefan Liebler <stli@linux.ibm.com>

I just remembered that the tree is in slushy freeze.  Carlos, would you 
approve this?  I will rebase the malloc hooks patchset on top of this.

Thanks,
Siddhesh

Re: [PATCH] Exclude tst-realloc from tests-mcheck

[Carlos O'Donell]

On 7/6/21 12:12 PM, Siddhesh Poyarekar wrote:
> On 7/6/21 9:31 PM, Siddhesh Poyarekar via Libc-alpha wrote:
>> The realloc (NULL, 0) test in tst-realloc fails with gcc 7.x but
>> passes with newer gcc.  This is because a newer gcc transforms the
>> realloc call to malloc (0), thus masking the bug in mcheck.
>>
>> Disable the test with mcheck for now.  The malloc removal patchset
>> will fix this and then remove this test from the exclusion list.
>>
>> I'll push this soon if there are no objections.  I'll also post an
>> updated malloc hooks patchset with these issues fixed.
>>
>> Reported-by: Stefan Liebler <stli@linux.ibm.com>
> 
> I just remembered that the tree is in slushy freeze.  Carlos, would you approve this?  I will rebase the malloc hooks patchset on top of this.

This is a non-ABI bug fix which is OK in the slushy freeze which only
coves ABI changes.

-- 
Cheers,
Carlos.

Re: [PATCH] Exclude tst-realloc from tests-mcheck

[Carlos O'Donell]

On 7/6/21 12:01 PM, Siddhesh Poyarekar via Libc-alpha wrote:
> The realloc (NULL, 0) test in tst-realloc fails with gcc 7.x but
> passes with newer gcc.  This is because a newer gcc transforms the
> realloc call to malloc (0), thus masking the bug in mcheck.
> 
> Disable the test with mcheck for now.  The malloc removal patchset
> will fix this and then remove this test from the exclusion list.
> 
> I'll push this soon if there are no objections.  I'll also post an
> updated malloc hooks patchset with these issues fixed.
> 
> Reported-by: Stefan Liebler <stli@linux.ibm.com>
> ---
>  malloc/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/malloc/Makefile b/malloc/Makefile
> index 2f9b3d596d..2af1203a0a 100644
> --- a/malloc/Makefile
> +++ b/malloc/Makefile
> @@ -93,7 +93,8 @@ tests-exclude-mcheck = tst-mallocstate \
>  	tst-malloc-usable-tunables \
>  	tst-malloc_info \
>  	tst-memalign \
> -	tst-posix_memalign
> +	tst-posix_memalign \
> +	tst-posix-realloc
>  
>  tests-mcheck = $(filter-out $(tests-exclude-mcheck), $(tests))
  
LGTM.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

-- 
Cheers,
Carlos.

Re: [PATCH] Exclude tst-realloc from tests-mcheck

[Stefan Liebler]

On 06/07/2021 19:59, Carlos O'Donell wrote:
> On 7/6/21 12:01 PM, Siddhesh Poyarekar via Libc-alpha wrote:
>> The realloc (NULL, 0) test in tst-realloc fails with gcc 7.x but
>> passes with newer gcc.  This is because a newer gcc transforms the
>> realloc call to malloc (0), thus masking the bug in mcheck.
>>
>> Disable the test with mcheck for now.  The malloc removal patchset
>> will fix this and then remove this test from the exclusion list.
>>
>> I'll push this soon if there are no objections.  I'll also post an
>> updated malloc hooks patchset with these issues fixed.
>>
>> Reported-by: Stefan Liebler <stli@linux.ibm.com>
>> ---
>>  malloc/Makefile | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/malloc/Makefile b/malloc/Makefile
>> index 2f9b3d596d..2af1203a0a 100644
>> --- a/malloc/Makefile
>> +++ b/malloc/Makefile
>> @@ -93,7 +93,8 @@ tests-exclude-mcheck = tst-mallocstate \
>>  	tst-malloc-usable-tunables \
>>  	tst-malloc_info \
>>  	tst-memalign \
>> -	tst-posix_memalign
>> +	tst-posix_memalign \
>> +	tst-posix-realloc
>>  
>>  tests-mcheck = $(filter-out $(tests-exclude-mcheck), $(tests))
>   
> LGTM.
> 
> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> 

Hi Siddhesh,

Thanks for adding the test to the exclude list.
But unfortunately it is still failing as there is a typo. The test is
named "tst-realloc" instead of "tst-posix-realloc".

Bye,
Stefan

Re: [PATCH] Exclude tst-realloc from tests-mcheck

[Siddhesh Poyarekar]

On 7/7/21 1:19 PM, Stefan Liebler wrote:
> Thanks for adding the test to the exclude list.
> But unfortunately it is still failing as there is a typo. The test is
> named "tst-realloc" instead of "tst-posix-realloc".

Terribly sorry about that, I have pushed the correct fix now.

Siddhesh

Re: [PATCH] Exclude tst-realloc from tests-mcheck

[Stefan Liebler]

On 07/07/2021 09:59, Siddhesh Poyarekar wrote:
> On 7/7/21 1:19 PM, Stefan Liebler wrote:
>> Thanks for adding the test to the exclude list.
>> But unfortunately it is still failing as there is a typo. The test is
>> named "tst-realloc" instead of "tst-posix-realloc".
> 
> Terribly sorry about that, I have pushed the correct fix now.
> 
> Siddhesh

No problem.
Thanks.