From: Carlos O'Donell <carlos@redhat.com>
To: Andreas Schwab <schwab@suse.de>, libc-alpha@sourceware.org
Subject: Re: [PATCH] Fix crash in resolver on memory allocation failure (bug 23005)
Date: Tue, 27 Mar 2018 15:20:00 -0000 [thread overview]
Message-ID: <436cba8c-94ce-5c3b-e429-dba6256c67c0@redhat.com> (raw)
In-Reply-To: <mvmo9j9byo9.fsf@suse.de>
On 03/27/2018 05:28 AM, Andreas Schwab wrote:
> [BZ #23005]
> * resolv/res_send.c (__res_context_send): Return ENOMEM if
> allocation of private copy of nsaddr_list fails.
> ---
> resolv/res_send.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/resolv/res_send.c b/resolv/res_send.c
> index dde0425a33..7debf143f7 100644
> --- a/resolv/res_send.c
> +++ b/resolv/res_send.c
> @@ -471,6 +471,11 @@ __res_context_send (struct resolv_context *ctx,
> '\0',
> sizeof (struct sockaddr_in6)
> - sizeof (struct sockaddr_in));
> + else
> + {
> + __set_errno (ENOMEM);
OK.
> + return -1;
OK, I reviewed the call chain to get there and it looks like -1 should
go all the way to the caller.
> + }
> }
> EXT(statp).nscount = statp->nscount;
> }
>
LGTM.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
--
Cheers,
Carlos.
prev parent reply other threads:[~2018-03-27 15:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 10:28 Andreas Schwab
2018-03-27 15:20 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=436cba8c-94ce-5c3b-e429-dba6256c67c0@redhat.com \
--to=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).