public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] manual/jobs.texi: Add missing @item EPERM for getpgid
@ 2023-08-24 19:36 Mark Wielaard
  2023-08-24 19:55 ` Sam James
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Wielaard @ 2023-08-24 19:36 UTC (permalink / raw)
  To: libc-alpha; +Cc: Mark Wielaard

From: Mark Wielaard <mark@klomp.org>

The missing @item makes it look like errno will be set to ESRCH
if a cross-session getpgid is not permitted.

Found by ulfvonbelow on irc.
---
 manual/job.texi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/manual/job.texi b/manual/job.texi
index 42cb9fb26d..8157f13a1c 100644
--- a/manual/job.texi
+++ b/manual/job.texi
@@ -1133,6 +1133,7 @@ following @code{errno} error conditions are defined for this function:
 @table @code
 @item ESRCH
 There is no process with the given process ID @var{pid}.
+@item EPERM
 The calling process and the process specified by @var{pid} are in
 different sessions, and the implementation doesn't allow to access the
 process group ID of the process with ID @var{pid} from the calling
-- 
2.39.3


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] manual/jobs.texi: Add missing @item EPERM for getpgid
  2023-08-24 19:36 [PATCH] manual/jobs.texi: Add missing @item EPERM for getpgid Mark Wielaard
@ 2023-08-24 19:55 ` Sam James
  2023-08-25 10:07   ` Mark Wielaard
  0 siblings, 1 reply; 3+ messages in thread
From: Sam James @ 2023-08-24 19:55 UTC (permalink / raw)
  To: Mark Wielaard; +Cc: Mark Wielaard, libc-alpha


Mark Wielaard via Libc-alpha <libc-alpha@sourceware.org> writes:

> From: Mark Wielaard <mark@klomp.org>
>
> The missing @item makes it look like errno will be set to ESRCH
> if a cross-session getpgid is not permitted.
>
> Found by ulfvonbelow on irc.
> ---
>  manual/job.texi | 1 +
>  1 file changed, 1 insertion(+)

lgtm, thanks.

>
> diff --git a/manual/job.texi b/manual/job.texi
> index 42cb9fb26d..8157f13a1c 100644
> --- a/manual/job.texi
> +++ b/manual/job.texi
> @@ -1133,6 +1133,7 @@ following @code{errno} error conditions are defined for this function:
>  @table @code
>  @item ESRCH
>  There is no process with the given process ID @var{pid}.
> +@item EPERM
>  The calling process and the process specified by @var{pid} are in
>  different sessions, and the implementation doesn't allow to access the
>  process group ID of the process with ID @var{pid} from the calling


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] manual/jobs.texi: Add missing @item EPERM for getpgid
  2023-08-24 19:55 ` Sam James
@ 2023-08-25 10:07   ` Mark Wielaard
  0 siblings, 0 replies; 3+ messages in thread
From: Mark Wielaard @ 2023-08-25 10:07 UTC (permalink / raw)
  To: Sam James; +Cc: libc-alpha

Hi Sam,

On Thu, 2023-08-24 at 20:55 +0100, Sam James wrote:
> > From: Mark Wielaard <mark@klomp.org>
> > 
> > The missing @item makes it look like errno will be set to ESRCH
> > if a cross-session getpgid is not permitted.
> > 
> > Found by ulfvonbelow on irc.
> > ---
> >  manual/job.texi | 1 +
> >  1 file changed, 1 insertion(+)
> 
> lgtm, thanks.

Thanks. Pushed.

It is nice to immediately (after 15 minutes) see the updated snapshots
docs:
https://snapshots.sourceware.org/glibc/trunk/latest/manual/html_node/Process-Group-Functions.html#index-getpgid
Cheers,

Mark

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-08-25 10:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-24 19:36 [PATCH] manual/jobs.texi: Add missing @item EPERM for getpgid Mark Wielaard
2023-08-24 19:55 ` Sam James
2023-08-25 10:07   ` Mark Wielaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).