From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Alejandro Colomar <colomar.6.4.3@gmail.com>
Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org,
libc-alpha@sourceware.org
Subject: Re: [PATCH 04/10] system_data_types.7: Add float_t
Date: Fri, 25 Sep 2020 10:13:28 +0200 [thread overview]
Message-ID: <5090c977-c75f-66a4-848f-e7ed94510d16@gmail.com> (raw)
In-Reply-To: <20200925073140.173394-5-colomar.6.4.3@gmail.com>
Hi Alex,
A few comments here that also apply for the double_t patch.
Could you revise please?
On 9/25/20 9:31 AM, Alejandro Colomar wrote:
> Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>
> ---
> man7/system_data_types.7 | 36 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
> diff --git a/man7/system_data_types.7 b/man7/system_data_types.7
> index b04457bbf..238b9593b 100644
> --- a/man7/system_data_types.7
> +++ b/man7/system_data_types.7
> @@ -147,6 +147,42 @@ Conforming to: C99 and later; POSIX.1-2001 and later.
> .IP
> See also:
> .BR fenv (3)
> +.\"------------------------------------- float_t ----------------------/
> +.TP
> +.I float_t
> +.IP
> +Include:
> +.IR <math.h> .
> +.IP
> +The implementation's most efficient floating type at least as wide as
> +.IR float .
The C standard is rather terse here. Perhaps we could make the
reader's life a little easier. How about something like:
[[
This a type that is intended to be the implementation's
most efficient floating type that is at least as wide as
.IR float .
]]
> +Its type depends on the value of the macro
> +.BR FLT_EVAL_METHOD :
> +.RS
> +.IP *
> +0;
> +.I float_t
> +is
> +.IR float .
> +.IP *
> +1;
> +.I float_t
> +is
> +.IR double .
> +.IP *
> +2;
> +.I float_t
> +is
> +.IR "long double" .
> +.IP *
> +Other implementation-defined values.
> +.RE
I think we can format this better as a hanging list.
Something like this:
[[
.TP
0
.I float_t
is
.IR float .
.TP
1
.I float_t
is
.IR double .
.TP
2
.I float_t
is
.IR "long double" .
.IP
For other values of
.BR FLT_EVAL_METHOD ,
the type of
.I float_t
is implementation-defined.
]]
> +.IP
> +Conforming to: C99 and later; POSIX.1-2001 and later.
> +.IP
> +See also the
> +.I double_t
> +type in this page.
> .\"------------------------------------- gid_t ------------------------/
> .TP
> .I gid_t
Thanks,
Michael
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
next prev parent reply other threads:[~2020-09-25 8:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 7:31 [PATCH 00/10] Add types, and some fixes Alejandro Colomar
2020-09-25 7:31 ` [PATCH 01/10] system_data_types.7: ffix Alejandro Colomar
2020-09-25 7:57 ` Michael Kerrisk (man-pages)
2020-09-25 7:31 ` [PATCH 02/10] system_data_types.7: Add lconv Alejandro Colomar
2020-09-25 7:59 ` Michael Kerrisk (man-pages)
2020-09-25 7:31 ` [PATCH 03/10] lconv.3: New link to system_data_types(7) Alejandro Colomar
2020-09-25 8:00 ` Michael Kerrisk (man-pages)
2020-09-25 7:31 ` [PATCH 04/10] system_data_types.7: Add float_t Alejandro Colomar
2020-09-25 8:13 ` Michael Kerrisk (man-pages) [this message]
2020-09-25 8:22 ` Alejandro Colomar
2020-09-25 9:30 ` Michael Kerrisk (man-pages)
2020-09-25 11:19 ` [PATCH v2 " Alejandro Colomar
2020-09-25 12:01 ` Michael Kerrisk (man-pages)
2020-09-25 7:31 ` [PATCH 05/10] float_t.3: New link to system_data_types(7) Alejandro Colomar
2020-09-25 12:01 ` Michael Kerrisk (man-pages)
2020-09-25 7:31 ` [PATCH 06/10] system_data_types.7: Add double_t Alejandro Colomar
2020-09-25 11:22 ` [PATCH v2 " Alejandro Colomar
2020-09-25 12:01 ` [PATCH " Michael Kerrisk (man-pages)
2020-09-25 7:31 ` [PATCH 07/10] double_t.3: New link to system_data_types(7) Alejandro Colomar
2020-09-25 12:01 ` Michael Kerrisk (man-pages)
2020-09-25 7:31 ` [PATCH 08/10] seccomp.2: Remove unneeded cast Alejandro Colomar
2020-09-25 8:34 ` Michael Kerrisk (man-pages)
2020-09-25 8:42 ` Alejandro Colomar
2020-09-25 9:23 ` Michael Kerrisk (man-pages)
2020-09-25 7:31 ` [PATCH 09/10] seccomp.2: Use ARRAY_SIZE() macro instead of raw sizeof division Alejandro Colomar
2020-09-25 9:25 ` Michael Kerrisk (man-pages)
2020-09-25 7:31 ` [PATCH 10/10] getgrent_r.3: Declare variables with different types in different lines Alejandro Colomar
2020-09-25 7:57 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5090c977-c75f-66a4-848f-e7ed94510d16@gmail.com \
--to=mtk.manpages@gmail.com \
--cc=colomar.6.4.3@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-man@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).