public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: Florian Weimer <fweimer@redhat.com>,
	Helge Deller via Libc-alpha <libc-alpha@sourceware.org>
Cc: dave.anglin@bell.net
Subject: Re: [PATCH] hppa: Drop old parisc-specific MADV_* constants
Date: Fri, 10 Feb 2023 11:48:50 +0100	[thread overview]
Message-ID: <516401c6-2652-4856-0706-1083accc4b67@gmx.de> (raw)
In-Reply-To: <875yc9j02o.fsf@oldenburg.str.redhat.com>

On 2/10/23 11:18, Florian Weimer wrote:
> * Helge Deller via Libc-alpha:
>
>> The Linux kernel upstream commit 71bdea6f798b ("parisc: Align parisc
>> MADV_XXX constants with all other architectures") dropped the
>> parisc-specific MADV_* values in favour of the same constants as
>> other architectures. In the same commit a wrapper was added which
>> translates the old values to the standard MADV_* values to avoid
>> breakage of existing programs.
>> This upstream patch has been downported to all stable kernel trees as
>> well.
>
> What about qemu-user?  Maybe it has always worked?

qemu-user was broken before, which is why I noticed that difference at all,
and which is the reason I came up with the kernel patch.
I did sent a fix for qemu-user too, which was applied some days ago:
https://gitlab.com/qemu-project/qemu/-/commit/4530deb1fe81152ae2384a56eb7edb5467f894fa

>> This patch now drops the parisc specific constants from glibc to
>> allow newly compliled programs to use the standard MADV_* constants.
>
> I appreciate the simplification, but I think this needs a NEWS file
> update, spelling out the required kernel versions on hppa if the madvise
> function is used.

Maybe add to the "Deprecated and removed features, and other changes affecting compatibility:"
section something like this?

* In the Linux kernel for the hppa/parisc architecture some of the MADV_ constants
   were changed to have the same values as the other architectures.
   New programs compiled with this glibc version and which use the madvise() call will
   require at least Linux kernels version 6.2, alternatively stable kernels
   from version 6.1.6, version 5.15.87 or version 5.10.163.

Helge

  reply	other threads:[~2023-02-10 10:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-10  9:23 Helge Deller
2023-02-10 10:18 ` Florian Weimer
2023-02-10 10:48   ` Helge Deller [this message]
2023-02-10 11:04     ` Helge Deller
2023-02-10 11:44     ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516401c6-2652-4856-0706-1083accc4b67@gmx.de \
    --to=deller@gmx.de \
    --cc=dave.anglin@bell.net \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).