From: Florian Weimer <fweimer@redhat.com>
To: Helge Deller <deller@gmx.de>
Cc: Helge Deller via Libc-alpha <libc-alpha@sourceware.org>,
dave.anglin@bell.net
Subject: Re: [PATCH] hppa: Drop old parisc-specific MADV_* constants
Date: Fri, 10 Feb 2023 12:44:17 +0100 [thread overview]
Message-ID: <87zg9lhhim.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <516401c6-2652-4856-0706-1083accc4b67@gmx.de> (Helge Deller's message of "Fri, 10 Feb 2023 11:48:50 +0100")
* Helge Deller:
> qemu-user was broken before, which is why I noticed that difference at all,
> and which is the reason I came up with the kernel patch.
> I did sent a fix for qemu-user too, which was applied some days ago:
> https://gitlab.com/qemu-project/qemu/-/commit/4530deb1fe81152ae2384a56eb7edb5467f894fa
Thanks for providing this context.
>>> This patch now drops the parisc specific constants from glibc to
>>> allow newly compliled programs to use the standard MADV_* constants.
>>
>> I appreciate the simplification, but I think this needs a NEWS file
>> update, spelling out the required kernel versions on hppa if the madvise
>> function is used.
>
> Maybe add to the "Deprecated and removed features, and other changes
> affecting compatibility:" section something like this?
Yes, exactly.
> * In the Linux kernel for the hppa/parisc architecture some of the MADV_ constants
> were changed to have the same values as the other architectures.
> New programs compiled with this glibc version and which use the madvise() call will
> require at least Linux kernels version 6.2, alternatively stable kernels
> from version 6.1.6, version 5.15.87 or version 5.10.163.
Shorter lines please, and no () after function names in
documentation. 8-) Rest looks fine.
Thanks,
Florian
prev parent reply other threads:[~2023-02-10 11:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 9:23 Helge Deller
2023-02-10 10:18 ` Florian Weimer
2023-02-10 10:48 ` Helge Deller
2023-02-10 11:04 ` Helge Deller
2023-02-10 11:44 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg9lhhim.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=dave.anglin@bell.net \
--cc=deller@gmx.de \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).