From: Peter Bergner <bergner@linux.ibm.com>
To: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH] powerpc: Fix ld.so address determination for PCREL mode (bug 31640)
Date: Sat, 13 Apr 2024 18:07:13 -0500 [thread overview]
Message-ID: <52248432-2d0f-4249-a003-ce9b66d859e2@linux.ibm.com> (raw)
In-Reply-To: <87edb92vsi.fsf@oldenburg.str.redhat.com>
On 4/13/24 9:15 AM, Florian Weimer wrote:
> This seems to have stopped working with some GCC 14 versions,
> which clobber r2. With other compilers, the kernel-provided
> r2 value is still available at this point.
With PCREL, r2 is just another volatile/caller saved register.
That said, it wasn't until GCC commit 1bbb169fe6f9 where we
actually started using it. Thanks for finding and fixing this!
LGTM
Reviewed-by: Peter Bergner <bergner@linux.ibm.com>
Peter
prev parent reply other threads:[~2024-04-13 23:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-13 14:15 Florian Weimer
2024-04-13 23:07 ` Peter Bergner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52248432-2d0f-4249-a003-ce9b66d859e2@linux.ibm.com \
--to=bergner@linux.ibm.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).