From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH] Fix compiler issue with mmap_internal
Date: Fri, 29 Oct 2021 09:14:25 -0300 [thread overview]
Message-ID: <56cc5592-0dd6-a830-dca8-9d5470c06d39@linaro.org> (raw)
In-Reply-To: <20211028212717.2311696-1-shorne@gmail.com>
On 28/10/2021 18:27, Stafford Horne via Libc-alpha wrote:
> Compiling mmap_internal fails to compile when we use -1 for MMAP2_PAGE_UNIT
> on 32 bit architectures. The error is as follows:
>
> ../sysdeps/unix/sysv/linux/mmap_internal.h:30:8: error: unknown type
> name 'uint64_t'
> |
> 30 | static uint64_t page_unit;
> |
> | ^~~~~~~~
>
> Fix by adding including stdint.h.
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> sysdeps/unix/sysv/linux/mmap_internal.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sysdeps/unix/sysv/linux/mmap_internal.h b/sysdeps/unix/sysv/linux/mmap_internal.h
> index 5ca6976191..35e112cc77 100644
> --- a/sysdeps/unix/sysv/linux/mmap_internal.h
> +++ b/sysdeps/unix/sysv/linux/mmap_internal.h
> @@ -19,6 +19,8 @@
> #ifndef MMAP_INTERNAL_LINUX_H
> #define MMAP_INTERNAL_LINUX_H 1
>
> +#include <stdint.h>
> +
> /* This is the minimum mmap2 unit size accept by the kernel. An architecture
> with multiple minimum page sizes (such as m68k) might define it as -1 and
> thus it will queried at runtime. */
>
prev parent reply other threads:[~2021-10-29 12:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 21:27 Stafford Horne
2021-10-29 12:14 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56cc5592-0dd6-a830-dca8-9d5470c06d39@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).