Re: ☠ Buildbot (Sourceware): glibc-snapshots-trunk - failed compile (failure) (master)

Re: ☠ Buildbot (Sourceware): glibc-snapshots-trunk - failed compile (failure) (master)

[H.J. Lu]

On Thu, Apr 25, 2024 at 5:21 AM <builder@sourceware.org> wrote:
>
> A new failure has been detected on builder glibc-snapshots-trunk while building glibc.
>
> Full details are available at:
>     https://builder.sourceware.org/buildbot/#/builders/264/builds/382
>
> Build state: failed compile (failure)
> Revision: 3a3a4497421422aa854c855cbe5110ca7d598ffc
> Worker: snapshots
> Build Reason: (unknown)
> Blamelist: Adhemerval Zanella <adhemerval.zanella@linaro.org>, Aurelien Jarno <aurelien@aurel32.net>, Carlos O'Donell <carlos@redhat.com>, Florian Weimer <fweimer@redhat.com>, H.J. Lu <hjl.tools@gmail.com>, Samuel Thibault <samuel.thibault@ens-lyon.org>, Wilco Dijkstra <wilco.dijkstra@arm.com>, caiyinyu <caiyinyu@loongson.cn>
>
> Steps:
>
> - 0: worker_preparation ( success )
>
> - 1: git checkout ( success )
>     Logs:
>         - stdio: https://builder.sourceware.org/buildbot/#/builders/264/builds/382/steps/1/logs/stdio
>
> - 2: rm -rf glibc-build ( success )
>     Logs:
>         - stdio: https://builder.sourceware.org/buildbot/#/builders/264/builds/382/steps/2/logs/stdio
>
> - 3: configure ( success )
>     Logs:
>         - stdio: https://builder.sourceware.org/buildbot/#/builders/264/builds/382/steps/3/logs/stdio
>         - config.log: https://builder.sourceware.org/buildbot/#/builders/264/builds/382/steps/3/logs/config_log
>
> - 4: make dist ( failure )
>     Logs:
>         - stdio: https://builder.sourceware.org/buildbot/#/builders/264/builds/382/steps/4/logs/stdio
>

On Fedora 40, "make INSTALL" generates a slightly different INSTALL:

diff --git a/INSTALL b/INSTALL
index 2f2d12c335..1047585695 100644
--- a/INSTALL
+++ b/INSTALL
@@ -21,11 +21,11 @@ allows removing the whole build directory in case
an error occurs, which
 is the safest way to get a fresh start and should always be done.

    From your object directory, run the shell script ‘configure’ located
-at the top level of the source tree.  In the scenario above, you’d type

                            ^
+at the top level of the source tree.  In the scenario above, you'd type

                            ^

-- 
H.J.

Re: ☠ Buildbot (Sourceware): glibc-snapshots-trunk - failed compile (failure) (master)

[Mark Wielaard]

Hi,

On Thu, 2024-04-25 at 08:29 -0700, H.J. Lu wrote:
> On Thu, Apr 25, 2024 at 5:21 AM <builder@sourceware.org> wrote:
> > 
> > A new failure has been detected on builder glibc-snapshots-trunk while building glibc.
> > 
> > Full details are available at:
> >     https://builder.sourceware.org/buildbot/#/builders/264/builds/382
> > 
> > 
> > - 4: make dist ( failure )
> >     Logs:
> >         - stdio: https://builder.sourceware.org/buildbot/#/builders/264/builds/382/steps/4/logs/stdio
> > 
> 
> On Fedora 40, "make INSTALL" generates a slightly different INSTALL:
> 
> diff --git a/INSTALL b/INSTALL
> index 2f2d12c335..1047585695 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -21,11 +21,11 @@ allows removing the whole build directory in case
> an error occurs, which
>  is the safest way to get a fresh start and should always be done.
> 
>     From your object directory, run the shell script ‘configure’ located
> -at the top level of the source tree.  In the scenario above, you’d type
> 
>                             ^
> +at the top level of the source tree.  In the scenario above, you'd type
> 
>                             ^
> 

I had to look 6 times till I saw the difference between the you’d and
you'd :)

Does anybody know what (which package upgrade) exactly caused this? And
what is "correct" in this case?

Maybe we should just spell it out?
"In the scenario above, you would type..."

Currently the snapshots are build using fedora-latest, which indeed
just switched to Fedora 40. We could use a distro that updates less
frequently, like debian-stable, if we don't want to be bothered by
these faster moving distros.

Cheers,

Mark

Re: ☠ Buildbot (Sourceware): glibc-snapshots-trunk - failed compile (failure) (master)

[Andreas K. Huettel]

[-- Attachment #1: Type: text/plain, Size: 1844 bytes --]

> > diff --git a/INSTALL b/INSTALL
> > index 2f2d12c335..1047585695 100644
> > --- a/INSTALL
> > +++ b/INSTALL
> > @@ -21,11 +21,11 @@ allows removing the whole build directory in case
> > an error occurs, which
> >  is the safest way to get a fresh start and should always be done.
> > 
> >     From your object directory, run the shell script ‘configure’ located
> > -at the top level of the source tree.  In the scenario above, you’d type
> > 
> >                             ^
> > +at the top level of the source tree.  In the scenario above, you'd type
> > 
> >                             ^
> > 
> 
> I had to look 6 times till I saw the difference between the you’d and
> you'd :)
> 
> Does anybody know what (which package upgrade) exactly caused this? And
> what is "correct" in this case?

In general that's texinfo, and the equivalent change was introduced elsewhere in 
(from memory) 2.38. 

commit 84e93afc734a3c30e35ed2d21466a44259ac577e
Author: Paul Eggert <eggert@cs.ucla.edu>
Date:   Thu Jun 29 09:20:41 2023 -0700
    Switch to UTF-8 for INSTALL
    This makes it slightly easier to read, and these days
    everybody can read UTF-8.

Now for what changed precisely in Fedora 40 you'll have to ask someone else...


> Maybe we should just spell it out?
> "In the scenario above, you would type..."
> 
> Currently the snapshots are build using fedora-latest, which indeed
> just switched to Fedora 40. We could use a distro that updates less
> frequently, like debian-stable, if we don't want to be bothered by
> these faster moving distros.

Millenial youngsters and their fancy unicode... :o)

-- 
Andreas K. Hüttel
dilfridge@gentoo.org
Gentoo Linux developer 
(council, comrel, toolchain, base-system, perl, libreoffice)
https://wiki.gentoo.org/wiki/User:Dilfridge

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: ☠ Buildbot (Sourceware): glibc-snapshots-trunk - failed compile (failure) (master)

[Mark Wielaard]

Hi Andreas,

On Fri, Apr 26, 2024 at 10:25:23AM +1100, Andreas K. Huettel wrote:
> > > diff --git a/INSTALL b/INSTALL
> > > index 2f2d12c335..1047585695 100644
> > > --- a/INSTALL
> > > +++ b/INSTALL
> > > @@ -21,11 +21,11 @@ allows removing the whole build directory in case
> > > an error occurs, which
> > >  is the safest way to get a fresh start and should always be done.
> > > 
> > >     From your object directory, run the shell script ‘configure’ located
> > > -at the top level of the source tree.  In the scenario above, you’d type
> > > 
> > >                             ^
> > > +at the top level of the source tree.  In the scenario above, you'd type
> > > 
> > >                             ^
> > > 
> > 
> > I had to look 6 times till I saw the difference between the you’d and
> > you'd :)
> > 
> > Does anybody know what (which package upgrade) exactly caused this? And
> > what is "correct" in this case?
> 
> In general that's texinfo, and the equivalent change was introduced elsewhere in 
> (from memory) 2.38. 
> 
> commit 84e93afc734a3c30e35ed2d21466a44259ac577e
> Author: Paul Eggert <eggert@cs.ucla.edu>
> Date:   Thu Jun 29 09:20:41 2023 -0700
>     Switch to UTF-8 for INSTALL
>     This makes it slightly easier to read, and these days
>     everybody can read UTF-8.
> 
> Now for what changed precisely in Fedora 40 you'll have to ask someone else...

Aha, thanks. So it depends on whether --disable-encoding is given to
makeinfo.

So this seems a slight difference between texinfo 7.0.3 (Fedora 39)
and texinfo 7.1 (Fedora 40). With 7.1 some single quotes ('), like in
"Don't" are no longer translated as open-quotes (’).

I don't fully understand what the change was. It seems 7.1 has
ASCII_DASHES_AND_QUOTES default to on. But I don't understand how to
turn that off.

> > Maybe we should just spell it out?
> > "In the scenario above, you would type..."

But it is for almost all contractions, so that is not a good suggestio
in general.

> > Currently the snapshots are build using fedora-latest, which indeed
> > just switched to Fedora 40. We could use a distro that updates less
> > frequently, like debian-stable, if we don't want to be bothered by
> > these faster moving distros.
> 
> Millenial youngsters and their fancy unicode... :o)

I don't mind the fancy unicode in general, but for quote characters it
certainly is a little confusion.

Maybe the simplest "solution" is turning --disable-encoding back on?
At least that seems to generate the same (boring ASCII only) INSTALL
file with both 7.0.3 and 7.1.

Cheers,

Mark

Re: ☠ Buildbot (Sourceware): glibc-snapshots-trunk - failed compile (failure) (master)

[Andreas K. Huettel]

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

> 
> Maybe the simplest "solution" is turning --disable-encoding back on?
> At least that seems to generate the same (boring ASCII only) INSTALL
> file with both 7.0.3 and 7.1.
> 

Alternatively, we regenerate to 7.1 and call it the new baseline...

[[I just checked and in Gentoo we even only have 7.1 left at the moment
(though restoring the old version would be easy).]]

Whatever we do with unicode will lead to failed checks somewhere then
though.

> Cheers,
> 
> Mark
> 


-- 
Andreas K. Hüttel
dilfridge@gentoo.org
Gentoo Linux developer 
(council, comrel, toolchain, base-system, perl, libreoffice)
https://wiki.gentoo.org/wiki/User:Dilfridge

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: ☠ Buildbot (Sourceware): glibc-snapshots-trunk - failed compile (failure) (master)

[Mark Wielaard]

Hi Andreas,

On Fri, 2024-04-26 at 21:22 +1100, Andreas K. Huettel wrote:
> > 
> > Maybe the simplest "solution" is turning --disable-encoding back on?
> > At least that seems to generate the same (boring ASCII only) INSTALL
> > file with both 7.0.3 and 7.1.
> 
> Alternatively, we regenerate to 7.1 and call it the new baseline...
> 
> [[I just checked and in Gentoo we even only have 7.1 left at the moment
> (though restoring the old version would be easy).]]

That works for me. The snapshot builder obviously (now) uses 7.1
already. And it would only really affect any release manager. Do we
have a page documenting the version of tools needed to make dist?

> Whatever we do with unicode will lead to failed checks somewhere then
> though.

Right. So we could also just decide the tools aren't really ready for
the new shiny unicode world yet and reintroduce --disable-encoding for
now and try again in a year or two for the INSTALL file.

Cheers,

Mark