From: Xi Ruoyao <xry111@xry111.site>
To: Zack Weinberg <zack@owlfolio.org>, libc-alpha@sourceware.org
Subject: Re: [PATCH] Add config.log to .gitignore
Date: Thu, 23 Mar 2023 00:26:02 +0800 [thread overview]
Message-ID: <5ba7d99d44e6bea1a0159a5f2b421995cb1f95f2.camel@xry111.site> (raw)
In-Reply-To: <b2e4ec30-f15c-8b30-5aab-1aff250054e5@owlfolio.org>
On Wed, 2023-03-22 at 12:01 -0400, Zack Weinberg via Libc-alpha wrote:
> On 2023-03-21 10:10 AM, 荣涛 via Libc-alpha wrote:
> > > How the config.log file could ever be here?
> > You are right, sorry, my mistake.
>
> I think the patch is desirable anyway. If someone makes a mistake and
> runs configure in the source directory, configure errors out, but it
> does so *after* creating config.log in the source directory. If this
> hypothetical someone goes on to create a separate build directory and
> do some hacking, and eventually runs 'git commit -a' without carefully
> checking what files are new or modified in the source directory,
> config.log could get added to the commit. Adding config.log to
> .gitignore protects against this chain of human errors.
I guess you mean "git add .", not "git commit -a". The latter won't add
config.log even it's there.
I'll not object if the others think this patch can prevent a human error
from "git add .", but I just want to say "don't use `git add .`, unless,
maybe, you've visually inspected the output of `git status`".
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2023-03-22 16:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 12:24 Rong Tao
2023-03-21 12:38 ` Xi Ruoyao
2023-03-21 14:10 ` =?gb18030?B?yNnMzg==?=
2023-03-22 16:01 ` Zack Weinberg
2023-03-22 16:26 ` Xi Ruoyao [this message]
2023-03-22 20:14 ` Zack Weinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ba7d99d44e6bea1a0159a5f2b421995cb1f95f2.camel@xry111.site \
--to=xry111@xry111.site \
--cc=libc-alpha@sourceware.org \
--cc=zack@owlfolio.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).