From: Carlos O'Donell <carlos@redhat.com>
To: "Adhemerval Zanella" <adhemerval.zanella@linaro.org>,
libc-alpha@sourceware.org, "Vineet Gupta" <vineetg@rivosinc.com>,
"Ludovic Courtès" <ludo@gnu.org>
Subject: Re: [PATCH v2 3/3] scripts/build-many-glibcs.py: Remove unused RANLIB and STRIP option
Date: Wed, 11 Jan 2023 15:28:57 -0500 [thread overview]
Message-ID: <5cfb7197-0882-f625-eb53-ca56f6504699@redhat.com> (raw)
In-Reply-To: <20221206160243.455627-4-adhemerval.zanella@linaro.org>
On 12/6/22 11:02, Adhemerval Zanella wrote:
LGTM.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> ---
> scripts/build-many-glibcs.py | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py
> index a49f50b792..32f336366c 100755
> --- a/scripts/build-many-glibcs.py
> +++ b/scripts/build-many-glibcs.py
> @@ -1521,8 +1521,6 @@ class GlibcPolicyDefault(object):
> '--host=%s' % glibc.triplet,
> 'CC=%s' % glibc.tool_name('gcc'),
> 'CXX=%s' % glibc.tool_name('g++'),
> - 'RANLIB=%s' % glibc.tool_name('ranlib'),
> - 'STRIP=%s' % glibc.tool_name('strip'),
OK. Agreed, these aren't used and we should make this as concise as possible.
> ]
> if glibc.os == 'gnu':
> self.configure_args.append('MIG=%s' % glibc.tool_name('mig'))
--
Cheers,
Carlos.
prev parent reply other threads:[~2023-01-11 20:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 16:02 [PATCH v2 0/3] Refactor binutils configure usage Adhemerval Zanella
2022-12-06 16:02 ` [PATCH v2 1/3] configure: Allow user override LD, AR, OBJCOPY, and GPROF Adhemerval Zanella
2023-01-11 20:25 ` Carlos O'Donell
2022-12-06 16:02 ` [PATCH v2 2/3] configure: Move nm, objdump, and readelf to LIBC_PROG_BINUTILS Adhemerval Zanella
2022-12-06 18:48 ` Adhemerval Zanella Netto
2023-01-11 20:30 ` Carlos O'Donell
2022-12-06 16:02 ` [PATCH v2 3/3] scripts/build-many-glibcs.py: Remove unused RANLIB and STRIP option Adhemerval Zanella
2023-01-11 20:28 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cfb7197-0882-f625-eb53-ca56f6504699@redhat.com \
--to=carlos@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=ludo@gnu.org \
--cc=vineetg@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).