Monday Patch Queue Review update (2021-06-21)

Monday Patch Queue Review update (2021-06-21)

[Carlos O'Donell]

Most recent meeting status is always here:
https://sourceware.org/glibc/wiki/PatchworkReviewMeetings#Update

Meeting: 2021-06-21 @ 0900h EST (UTC-5)

IRC: #glibc on OFTC.

    glibc 286 patches.
    Siddhesh ran the cleanup script.
    Lukasz has reviewed 64-bit time_t changes.
        Adhemerval has review delegated.
        https://sourceware.org/pipermail/libc-alpha/2021-June/127727.html
            Additional fixes for release.
            Avoids CRIO problems and optimizes usage when run on older kernels. 
    SA_RESTART change can be pushed later this week.
        Should switch to SA_ONSTACK also? Want to write a test case.
        SA_RESTART does not fix bz for longstanding cancellation issues, but it helps. 
    ABI changes in flight:
        librt review.
        libanl to move into libc.
        libnss_files
        libnss_dns
        libutil to move into libc. 
    Florian wants to Review ABI before release.
    HJ is looking at desirable for release "clone3 wrappers":
        https://patchwork.sourceware.org/project/glibc/list/?series=2252
        PTHREAD_STAKC_MIN fixes to mirror existing dyanmic stack size fixes.
            HJ to work on this patch for consistency. 
    gconv split out with .d directories.
        Ask DJ to review gconv split out .d patches? 
    HWCAP things on Arm had a regression in glibc 2.34
        This is for july when the ABI is frozen and look at regression bugs.
        https://sourceware.org/bugzilla/show_bug.cgi?id=27046 
    Carlos needs to review:
        https://patchwork.sourceware.org/project/glibc/patch/20210125135619.9695-1-hjl.tools@gmail.com/
        https://patchwork.sourceware.org/project/glibc/patch/20210202145733.545020-1-hjl.tools@gmail.com/ 
    Need review for Florian:
        https://sourceware.org/pipermail/libc-alpha/2021-June/127727.html
        https://sourceware.org/pipermail/libc-alpha/2021-June/127727.html 
    Carlos to post to libc-alpha that wiki page is up for blockers.
    Review starting at 43935
        libutil (small, self contained)
            https://patchwork.sourceware.org/project/glibc/list/?series=2334 

There was a quick discussion about the public LD_AUDIT request after patch review.

    Any detailed discussions need to happen on libc-alpha in public.
    Discussion of the Rice University post here:
        https://sourceware.org/pipermail/libc-alpha/2021-June/127636.html 
    LD_BIND_NOW? How do we handle it.
        Input how to fix it?
        We need BIND_NOW to have something to work with SVE.
            What do we do with SVE 
        NEON support broken on aarch64.
            Bump the LA_VERSION on Arm64
            Only supports version 2.
            Don't know how to fix this for SVE.
            Fixing it for NEON and SVE both is desirable. 
        Is BIND_NOW just an optimization or semantic issue?
        Bump LAV_CURRENT to 2 on all arches.
            Start calling la_symbind in more cases.
            Call early in the bind now scenario.
                For the bindnow call sites we add a check afterwards that the callback didn't request PLT_ENTER/PLT_EXIT hooks.
                If the hook check fails, we report a dlsym error or relocation error.
                Can we call the callbacks that early?
                Yes, already relocated. 

-- 
Cheers,
Carlos.