public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Stefan Liebler <stli@linux.ibm.com>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH] Fix race in pthread_mutex_lock while promoting to PTHREAD_MUTEX_ELISION_NP [BZ #23275]
Date: Thu, 14 Jun 2018 08:04:00 -0000	[thread overview]
Message-ID: <61452ecb-ec00-8d65-e211-18659819fc70@linux.ibm.com> (raw)
In-Reply-To: <e2d28723-790e-6fa2-082c-e953160765e1@linux.ibm.com>

> I've also retested tst-mutex10 without the remaining patch on multiple 
> s390x machines. I've found out, that it depends on the used gcc (at 
> least on s390x). On one machine, gcc 6 was used. With gcc 7 / 8, the 
> type of the mutex was loaded from memory multiple times.
> With gcc 6, it is loaded only one time and thus all threads are 
> promoting the mutex to PTHREAD_MUTEX_ELISION_NP. Then you don't see a fail.
> 
> On x86_64, I've used gcc 8. Perhaps I can try other gcc versions.
I've tried gcc 6, 7, 8 on x86_64:
-gcc 6: the mutex-type is only loaded one time from memory => no fails
-gcc 7/8: the mutex-type is loaded two times from memory => fails

  reply	other threads:[~2018-06-14  8:04 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-12 14:25 Stefan Liebler
2018-06-13  8:43 ` Florian Weimer
2018-06-13  9:18   ` Stefan Liebler
2018-06-13  9:36     ` Florian Weimer
2018-06-13 15:25       ` Stefan Liebler
2018-06-14  8:04         ` Stefan Liebler [this message]
2018-06-13 21:45     ` Tulio Magno Quites Machado Filho
2018-06-19  7:45 ` Stefan Liebler
2018-06-26  6:45   ` [PING][PATCH] " Stefan Liebler
2018-07-03  6:28     ` Stefan Liebler
2018-07-10  6:34       ` Stefan Liebler
2018-07-16 11:57         ` Stefan Liebler
2018-07-23  6:42           ` Stefan Liebler
2018-07-30  7:22             ` Stefan Liebler
2018-08-27  9:12               ` Stefan Liebler
2018-09-03  7:10                 ` Stefan Liebler
2018-09-10 12:01                   ` Stefan Liebler
2018-09-17 13:38 ` [PATCH] " Florian Weimer
2018-10-04 16:08   ` Stefan Liebler
2018-10-16 14:23     ` Florian Weimer
2018-10-17 10:36       ` Stefan Liebler
2018-10-18 13:24         ` [COMMITTED 2.27 / 2.28] " Stefan Liebler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61452ecb-ec00-8d65-e211-18659819fc70@linux.ibm.com \
    --to=stli@linux.ibm.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).