From: Paul Eggert <eggert@cs.ucla.edu>
To: Stafford Horne <shorne@gmail.com>,
GLIBC patches <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2] tst-tzset: output reason when creating 4GiB file fails
Date: Wed, 3 Nov 2021 12:14:52 -0700 [thread overview]
Message-ID: <61531402-fbc9-fcc9-93b9-f453901bf399@cs.ucla.edu> (raw)
In-Reply-To: <20211102233159.4094554-1-shorne@gmail.com>
On 11/2/21 16:31, Stafford Horne via Libc-alpha wrote:
> + {
> + printf ("creating timezone file of size: %" PRId64 "MiB failed.\n",
> + size / (1024 * 1024));
Why not simply print the size in bytes? Converting to MiB outputs less
information due to rounding, and is hardly worth the trouble here. Other
than that, looks fine.
next prev parent reply other threads:[~2021-11-03 19:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 23:31 Stafford Horne
2021-11-03 17:35 ` Adhemerval Zanella
2021-11-03 19:14 ` Paul Eggert [this message]
2021-11-03 20:30 ` Stafford Horne
2021-11-12 23:10 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61531402-fbc9-fcc9-93b9-f453901bf399@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=libc-alpha@sourceware.org \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).