* [PATCH v2] microblaze: Use the correct select syscall (BZ #28883)
@ 2022-02-16 16:55 Adhemerval Zanella
2022-02-16 17:11 ` Mark Hatle
0 siblings, 1 reply; 3+ messages in thread
From: Adhemerval Zanella @ 2022-02-16 16:55 UTC (permalink / raw)
To: libc-alpha; +Cc: mark.hatle
On Microblaze only __NR_newselect is implemented, even though kernel
advertise __NR_select on asm/unistd.h. Since microblaze is the
only architecture that undef __ASSUME_PSELECT, the generic code
change is simpler than chaging the architecture syscall number.
---
sysdeps/unix/sysv/linux/select.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sysdeps/unix/sysv/linux/select.c b/sysdeps/unix/sysv/linux/select.c
index 3bc8b0cc3d..a3f0a2eba7 100644
--- a/sysdeps/unix/sysv/linux/select.c
+++ b/sysdeps/unix/sysv/linux/select.c
@@ -108,7 +108,7 @@ __select64 (int nfds, fd_set *readfds, fd_set *writefds, fd_set *exceptfds,
ptv32 = &tv32;
}
- int r = SYSCALL_CANCEL (select, nfds, readfds, writefds, exceptfds, ptv32);
+ int r = SYSCALL_CANCEL (_newselect, nfds, readfds, writefds, exceptfds, ptv32);
if (timeout != NULL)
*timeout = valid_timeval_to_timeval64 (tv32);
return r;
--
2.32.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] microblaze: Use the correct select syscall (BZ #28883)
2022-02-16 16:55 [PATCH v2] microblaze: Use the correct select syscall (BZ #28883) Adhemerval Zanella
@ 2022-02-16 17:11 ` Mark Hatle
2022-02-16 19:22 ` Adhemerval Zanella
0 siblings, 1 reply; 3+ messages in thread
From: Mark Hatle @ 2022-02-16 17:11 UTC (permalink / raw)
To: Adhemerval Zanella, libc-alpha; +Cc: Hatle, Mark
acked-by: Mark Hatle <mark.hatle@xilinx.com>
This looks like a good alternative solution to me and will resolve the issue.
On 2/16/22 10:55 AM, Adhemerval Zanella wrote:
> On Microblaze only __NR_newselect is implemented, even though kernel
> advertise __NR_select on asm/unistd.h. Since microblaze is the
> only architecture that undef __ASSUME_PSELECT, the generic code
> change is simpler than chaging the architecture syscall number.
> ---
> sysdeps/unix/sysv/linux/select.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/unix/sysv/linux/select.c b/sysdeps/unix/sysv/linux/select.c
> index 3bc8b0cc3d..a3f0a2eba7 100644
> --- a/sysdeps/unix/sysv/linux/select.c
> +++ b/sysdeps/unix/sysv/linux/select.c
> @@ -108,7 +108,7 @@ __select64 (int nfds, fd_set *readfds, fd_set *writefds, fd_set *exceptfds,
> ptv32 = &tv32;
> }
>
> - int r = SYSCALL_CANCEL (select, nfds, readfds, writefds, exceptfds, ptv32);
> + int r = SYSCALL_CANCEL (_newselect, nfds, readfds, writefds, exceptfds, ptv32);
> if (timeout != NULL)
> *timeout = valid_timeval_to_timeval64 (tv32);
> return r;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] microblaze: Use the correct select syscall (BZ #28883)
2022-02-16 17:11 ` Mark Hatle
@ 2022-02-16 19:22 ` Adhemerval Zanella
0 siblings, 0 replies; 3+ messages in thread
From: Adhemerval Zanella @ 2022-02-16 19:22 UTC (permalink / raw)
To: Mark Hatle, libc-alpha; +Cc: Hatle, Mark
I will push this shortly.
On 16/02/2022 14:11, Mark Hatle wrote:
> acked-by: Mark Hatle <mark.hatle@xilinx.com>
>
> This looks like a good alternative solution to me and will resolve the issue.
>
> On 2/16/22 10:55 AM, Adhemerval Zanella wrote:
>> On Microblaze only __NR_newselect is implemented, even though kernel
>> advertise __NR_select on asm/unistd.h. Since microblaze is the
>> only architecture that undef __ASSUME_PSELECT, the generic code
>> change is simpler than chaging the architecture syscall number.
>> ---
>> sysdeps/unix/sysv/linux/select.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sysdeps/unix/sysv/linux/select.c b/sysdeps/unix/sysv/linux/select.c
>> index 3bc8b0cc3d..a3f0a2eba7 100644
>> --- a/sysdeps/unix/sysv/linux/select.c
>> +++ b/sysdeps/unix/sysv/linux/select.c
>> @@ -108,7 +108,7 @@ __select64 (int nfds, fd_set *readfds, fd_set *writefds, fd_set *exceptfds,
>> ptv32 = &tv32;
>> }
>> - int r = SYSCALL_CANCEL (select, nfds, readfds, writefds, exceptfds, ptv32);
>> + int r = SYSCALL_CANCEL (_newselect, nfds, readfds, writefds, exceptfds, ptv32);
>> if (timeout != NULL)
>> *timeout = valid_timeval_to_timeval64 (tv32);
>> return r;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-16 19:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-16 16:55 [PATCH v2] microblaze: Use the correct select syscall (BZ #28883) Adhemerval Zanella
2022-02-16 17:11 ` Mark Hatle
2022-02-16 19:22 ` Adhemerval Zanella
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).