public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] login: Use unsigned 32-bit types for seconds-since-epoch
Date: Wed, 3 Apr 2024 14:20:07 -0700	[thread overview]
Message-ID: <6289d40a-7989-4869-8f47-553263e4df7a@cs.ucla.edu> (raw)
In-Reply-To: <87sf02guiz.fsf@oldenburg.str.redhat.com>

On 4/3/24 11:39, Florian Weimer wrote:
> For consistency,
> if there is a 64-bit architecture that is coinstallable, define
> __WORDSIZE_TIME64_COMPAT32 to 1 on the 32-bit architectyre as well.

Could you explain the advantage of consistency here? User code almost 
invariably assignes ut_tv.tv_sec to time_t (this is true of every 
instance I found of ut_tv in Gnulib source code, for example). So 
changing this field's type on platforms where time_t is 32 bits will 
likely be ineffective in practice, and might cause more problems than it 
cures.

Since the _TIME_BITS==32 world is going away anyway by 2038, it might be 
better to leave the field types unchanged in that world, to lessen 
compatibility glitches before that world gives up its ghost.


  reply	other threads:[~2024-04-03 21:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-03 18:39 Florian Weimer
2024-04-03 21:20 ` Paul Eggert [this message]
2024-04-04  5:09   ` Florian Weimer
2024-04-05 12:46     ` Adhemerval Zanella Netto
2024-04-05 12:52       ` Florian Weimer
2024-04-05 13:32         ` Adhemerval Zanella Netto
2024-04-08 12:19           ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6289d40a-7989-4869-8f47-553263e4df7a@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).