From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: Stafford Horne <shorne@gmail.com>
Cc: GLIBC patches <libc-alpha@sourceware.org>
Subject: Re: [PATCH] malloc: Fix malloc debug for 2.35 onwards
Date: Tue, 16 Nov 2021 04:17:10 +0530 [thread overview]
Message-ID: <629dbe12-64c5-4307-183f-2c679a2cdd8c@gotplt.org> (raw)
In-Reply-To: <YZLMFpUfXOanE8wm@antec>
On 11/16/21 02:37, Stafford Horne wrote:
> I am not sure, after my patch the SHLIB_COMPAT usage is just there for compat
> symbols. As you mention using SHLIB_COMPAT to ensure libc_malloc_debug.so and
> libc.so have the same version seems strange, I would think that would be
> controlled by shlib-version or done out of the box.
Right, so it mostly works, i.e. you have symbols with version names:
...
> 00009bb4 g DF .text 00000030 GLIBC_2.35 memalign
> 0000a5a8 g DF .text 00000138 GLIBC_2.35 mallinfo
> 000091a0 g DF .text 00000180 GLIBC_2.35 malloc
> 0000a2ac g DF .text 000000f8 GLIBC_2.35 mallopt
...
but they're default versions, which is not desirable since we don't want
this library to be linkable. So you will need a new macro that always
creates the non-default symbol at the version that it was introduced.
Siddhesh
next prev parent reply other threads:[~2021-11-15 22:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 0:40 Stafford Horne
2021-11-15 2:34 ` Siddhesh Poyarekar
2021-11-15 2:40 ` Siddhesh Poyarekar
2021-11-15 21:07 ` Stafford Horne
2021-11-15 22:47 ` Siddhesh Poyarekar [this message]
2021-11-16 5:12 ` Stafford Horne
2021-11-16 5:15 ` Siddhesh Poyarekar
2021-11-16 5:29 ` Stafford Horne
2021-11-15 21:04 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=629dbe12-64c5-4307-183f-2c679a2cdd8c@gotplt.org \
--to=siddhesh@gotplt.org \
--cc=libc-alpha@sourceware.org \
--cc=shorne@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).