Re: [PATCH] malloc: Fix malloc debug for 2.35 onwards

[Stafford Horne <shorne@gmail.com>]

On Mon, Nov 15, 2021 at 08:10:42AM +0530, Siddhesh Poyarekar wrote:
> [sorry, hit send too soon]
> 
> On 11/15/21 08:04, Siddhesh Poyarekar wrote:
> > What symbols does this change generate?  Could you please share the
> > output of objdump -T malloc/libc_malloc_debug.so from your build?
> > 
> 
> Basically the idea of SHLIB_COMPAT usage here is twofold: first, to ensure
> that the symbol versions in libc_malloc_debug.so are at the exact same
> version as those in libc.so and second, to prevent linking against
> libc_malloc_debug.so.
> 
> In that sense, I think SHLIB_COMPAT usage is a hack.  The correct way would
> be to make a new macro like SHLIB_COMPAT, which creates non-default symbol
> version at the latest version of the libc symbol; i.e. for your port it
> would be malloc@GLIBC_2.35 and for x86_64 it would be malloc@GLIBC_2.2.5.

I am not sure, after my patch the SHLIB_COMPAT usage is just there for compat
symbols.  As you mention using SHLIB_COMPAT to ensure libc_malloc_debug.so and
libc.so have the same version seems strange, I would think that would be
controlled by shlib-version or done out of the box.

-Stafford