From: Carlos O'Donell <carlos@redhat.com>
To: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH] Add test for linking against most static libraries
Date: Fri, 28 Oct 2016 18:27:00 -0000 [thread overview]
Message-ID: <62ece8be-3904-0dd8-3433-75466dc80209@redhat.com> (raw)
In-Reply-To: <9c9a0748-7101-a6a0-297e-106886589d81@redhat.com>
On 10/28/2016 01:29 PM, Carlos O'Donell wrote:
> On 10/28/2016 10:51 AM, Carlos O'Donell wrote:
>> On 10/28/2016 08:57 AM, Florian Weimer wrote:
>>> 2016-10-28 Florian Weimer <fweimer@redhat.com>
>>>
>>> * elf/tst-linkall-static.c: New file.
>>> * elf/Makefile (tests-static): Add tst-linkall-static.
>>> (tst-linkall-static): Link against static libraries.
>>
>> LGTM. Thanks for increasing test coverage.
>>
>
> This breaks my i486 -Os build with a test build failures because
> it can't find crypt.h.
>
> I don't see that any of the sysdep selection mechanisms add
> crypt to the list, therefore you can't access crypt headers.
>
> However, the crypt/ tests themselves seem to get an absolute
> path added explicitly, so they work.
>
> The only other reference is from locale/Makefile which also
> adds -I../crypt via vpath and CFLAGS-*.
>
> I'm kinda baffled by this. We don't set it in config-sysdirs.
>
> I expect you have a local patch that hid this.
>
> I'm going to commit the following immediate fix:
>
> 2016-10-28 Carlos O'Donell <carlos@redhat.com>
>
> * elf/Makefile (CFALGS-tst-linkall-static): Define.
>
> diff --git a/elf/Makefile b/elf/Makefile
> index 82c7e05..a8d2bfe 100644
> --- a/elf/Makefile
> +++ b/elf/Makefile
> @@ -1280,6 +1280,7 @@ $(objpfx)tst-ldconfig-X.out : tst-ldconfig-X.sh $(objpfx)ldconfig
>
> $(objpfx)tst-dlsym-error: $(libdl)
>
> +CFLAGS-tst-linkall-static = -I../crypt
> $(objpfx)tst-linkall-static: \
> $(common-objpfx)math/libm.a \
> $(common-objpfx)crypt/libcrypt.a \
> ---
Without the typo (missing '.c' in CFLAGS rule).
--
Cheers,
Carlos.
prev parent reply other threads:[~2016-10-28 18:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 12:57 Florian Weimer
2016-10-28 14:51 ` Carlos O'Donell
2016-10-28 17:30 ` Carlos O'Donell
2016-10-28 17:33 ` Joseph Myers
2016-10-28 17:42 ` Florian Weimer
2016-10-28 17:48 ` Joseph Myers
2016-10-28 18:30 ` Carlos O'Donell
2016-10-28 20:16 ` Carlos O'Donell
2016-10-28 20:22 ` Joseph Myers
2016-10-29 2:41 ` Carlos O'Donell
2016-10-28 18:55 ` Florian Weimer
2016-10-28 20:08 ` Joseph Myers
2016-10-28 20:27 ` Florian Weimer
2016-10-28 20:52 ` Joseph Myers
2016-10-28 20:21 ` Carlos O'Donell
2016-10-28 18:27 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62ece8be-3904-0dd8-3433-75466dc80209@redhat.com \
--to=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).