From: Joseph Myers <joseph@codesourcery.com>
To: Carlos O'Donell <carlos@redhat.com>
Cc: Florian Weimer <fweimer@redhat.com>, <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Add test for linking against most static libraries
Date: Fri, 28 Oct 2016 17:33:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1610281732090.17460@digraph.polyomino.org.uk> (raw)
In-Reply-To: <9c9a0748-7101-a6a0-297e-106886589d81@redhat.com>
On Fri, 28 Oct 2016, Carlos O'Donell wrote:
> I'm kinda baffled by this. We don't set it in config-sysdirs.
>
> I expect you have a local patch that hid this.
I expect he happened to have a compiler that searched a system include
directory with crypt.h.
> I'm going to commit the following immediate fix:
>
> 2016-10-28 Carlos O'Donell <carlos@redhat.com>
>
> * elf/Makefile (CFALGS-tst-linkall-static): Define.
That's not the right fix. The right way to address such issues is a
wrapper header in include/.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2016-10-28 17:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 12:57 Florian Weimer
2016-10-28 14:51 ` Carlos O'Donell
2016-10-28 17:30 ` Carlos O'Donell
2016-10-28 17:33 ` Joseph Myers [this message]
2016-10-28 17:42 ` Florian Weimer
2016-10-28 17:48 ` Joseph Myers
2016-10-28 18:30 ` Carlos O'Donell
2016-10-28 20:16 ` Carlos O'Donell
2016-10-28 20:22 ` Joseph Myers
2016-10-29 2:41 ` Carlos O'Donell
2016-10-28 18:55 ` Florian Weimer
2016-10-28 20:08 ` Joseph Myers
2016-10-28 20:27 ` Florian Weimer
2016-10-28 20:52 ` Joseph Myers
2016-10-28 20:21 ` Carlos O'Donell
2016-10-28 18:27 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1610281732090.17460@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).