From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Siddhesh Poyarekar <siddhesh@gotplt.org>, libc-alpha@sourceware.org
Subject: Re: [PATCH 2/6] New internal function __access_noerrno
Date: Thu, 10 Nov 2016 12:15:00 -0000 [thread overview]
Message-ID: <67e3afd8-d1ea-ef52-dcf4-c8c4372a3410@linaro.org> (raw)
In-Reply-To: <9fee5a6f-bde3-6f5f-d8ee-5ab6c8771873@gotplt.org>
On 10/11/2016 03:44, Siddhesh Poyarekar wrote:
> On Wednesday 09 November 2016 12:30 AM, Siddhesh Poyarekar wrote:
>> I can hack at sysdeps/unix/sysv/linux/access.c and drop
>> sysdeps/unix/access_noerrno.c.
>
> Turns out I can't do this because I will be breaking non-Linux
> configurations that use the SYS_ prefix instead of the __NR_ prefix. I
> also discovered that I hadn't actually tested the code properly on
> aarch64 and it is broken, so I'll resend the patchset.
>
> Siddhesh
In this branch [1] I have a WIP for this. First patch basically
consolidates access Linux implementation and it uses the strategy
to check for __NR_access first (and since it on sysdeps/.../linux
it should not worry about __SYS_*).
Second one is the __access_errno implementation. It basically handles
the 3 cases (hurd, nacl, and Linux) by adding the __access_errno on
access.c.
I think it should a cleaner solution to __access_noerro (less macro
handling and build objects).
[1] https://github.com/zatrazz/glibc/commits/master-access_noerrno
next prev parent reply other threads:[~2016-11-10 12:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 14:43 [PATCH v5 0/6] glibc tunables Siddhesh Poyarekar
2016-10-24 14:43 ` [PATCH 2/6] New internal function __access_noerrno Siddhesh Poyarekar
2016-11-08 17:10 ` Adhemerval Zanella
2016-11-08 19:00 ` Siddhesh Poyarekar
2016-11-10 5:47 ` Siddhesh Poyarekar
2016-11-10 12:15 ` Adhemerval Zanella [this message]
2016-11-10 13:05 ` Siddhesh Poyarekar
2016-11-10 16:07 ` Adhemerval Zanella
2016-10-24 14:43 ` [PATCH 5/6] Enhance --enable-tunables to select tunables frontend at build time Siddhesh Poyarekar
2016-10-24 14:43 ` [PATCH 6/6] User manual documentation for tunables Siddhesh Poyarekar
2016-10-24 17:22 ` Joseph Myers
2016-10-26 9:53 ` Siddhesh Poyarekar
2016-10-24 14:43 ` [PATCH 4/6] Initialize tunable list with the GLIBC_TUNABLES environment variable Siddhesh Poyarekar
2016-10-24 15:01 ` Andreas Schwab
2016-10-26 9:48 ` Siddhesh Poyarekar
2016-10-24 14:43 ` [PATCH 1/6] Static inline functions for mallopt helpers Siddhesh Poyarekar
2016-10-26 17:51 ` DJ Delorie
2016-10-27 3:12 ` Siddhesh Poyarekar
2016-10-24 14:43 ` [PATCH 3/6] Add framework for tunables Siddhesh Poyarekar
2016-11-03 10:26 ` [PING][PATCH v5 0/6] glibc tunables Siddhesh Poyarekar
2016-11-08 5:37 ` [PING 2][PATCH " Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67e3afd8-d1ea-ef52-dcf4-c8c4372a3410@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).