From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
libc-alpha@sourceware.org, Florian Weimer <fweimer@redhat.com>
Cc: Dave Flogeras <dflogeras2@gmail.com>, James Clarke <jrtc27@debian.org>
Subject: Re: [PATCH v3 0/7] Fix getdents{64} regression on some FS
Date: Thu, 22 Jul 2021 10:28:27 +0200 [thread overview]
Message-ID: <6a2e134a-2a35-0834-f1fa-7b30ac9efb11@physik.fu-berlin.de> (raw)
In-Reply-To: <20201021141542.2003377-1-adhemerval.zanella@linaro.org>
Hi!
On 10/21/20 4:15 PM, Adhemerval Zanella wrote:
> This is updated version [1], rebased against master add with some
> suggestion from previous review. The main changes are:
>
> - The translation buffer is allocated as an auxiliarry one (instead
> of a reserved spacefrom the dirstream) and readdir might reallocate
> it if it finds a large entry.
>
> - Failures in non-LFS readdir (such as d_ino/d_off overflow or failure
> in expand the translation buffer) is ignored. This allows code that
> does not handle possible failure in readdir to successful read the
> rest of entries in the directory.
>
> - So minor fixes in dirent/tst-seekdir2.c
>
> - Added __attribute_deprecated_msg__ on getdirentries to redirect to
> getdents64.
>
> I have checked on x86_64-linux-gnu, powerpc64-linux-gnu and on some
> 32-bit ABIs arm-linux-gnueabihf, powerpc-linux-gnu, and sparcv9-linux-gnu.
Are there any news on this patch series? The bug is still present as far as I know.
Thanks,
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz@debian.org
`. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
next prev parent reply other threads:[~2021-07-22 8:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 14:15 Adhemerval Zanella
2020-10-21 14:15 ` [PATCH v3 1/7] linux: Do not skip entries with zero d_ino values [BZ #12165] Adhemerval Zanella
2020-10-21 14:15 ` [PATCH v3 2/7] linux: Use getdents64 on non-LFS readdir Adhemerval Zanella
2020-10-21 14:15 ` [PATCH v3 3/7] linux: Set internal DIR filepos as off64_t [BZ #23960, BZ #24050] Adhemerval Zanella
2020-10-21 14:15 ` [PATCH v3 4/7] linux: Add __readdir64_unlocked Adhemerval Zanella
2020-10-21 14:15 ` [PATCH v3 5/7] linux: Add __old_readdir64_unlocked Adhemerval Zanella
2020-10-21 14:15 ` [PATCH v3 6/7] linux: Use getdents64 on readdir64 compat implementation Adhemerval Zanella
2020-10-21 14:15 ` [PATCH v3 7/7] dirent: Deprecate getdirentries Adhemerval Zanella
2022-01-06 21:48 ` John Paul Adrian Glaubitz
2022-01-06 21:59 ` Sam James
2022-01-06 22:01 ` John Paul Adrian Glaubitz
2022-05-10 19:30 ` John Paul Adrian Glaubitz
2022-05-12 15:40 ` Adhemerval Zanella
2021-07-22 8:28 ` John Paul Adrian Glaubitz [this message]
2021-08-19 16:07 ` [PATCH v3 0/7] Fix getdents{64} regression on some FS John Paul Adrian Glaubitz
2021-08-19 16:19 ` Adhemerval Zanella
2021-08-19 16:50 ` John Paul Adrian Glaubitz
2021-08-19 16:52 ` Adhemerval Zanella
2021-08-19 17:02 ` John Paul Adrian Glaubitz
2021-08-19 17:15 ` Florian Weimer
2021-08-19 20:30 ` John Paul Adrian Glaubitz
2021-08-20 10:34 ` Dave Flogeras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a2e134a-2a35-0834-f1fa-7b30ac9efb11@physik.fu-berlin.de \
--to=glaubitz@physik.fu-berlin.de \
--cc=adhemerval.zanella@linaro.org \
--cc=dflogeras2@gmail.com \
--cc=fweimer@redhat.com \
--cc=jrtc27@debian.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).