public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Fix glibc 2.34 ABI omission (missing GLIBC_2.34 in dynamic loader)
Date: Mon, 13 Dec 2021 20:24:50 +0530	[thread overview]
Message-ID: <6af259d3-1123-5b5a-fe2b-7207d48e46af@gotplt.org> (raw)
In-Reply-To: <874k7c1z20.fsf@oldenburg.str.redhat.com>

On 12/13/21 17:45, Florian Weimer wrote:
> It's only possible to move symbols if version nodes exist on both
> sides.  Therefore, this patch adds a version node to ld.so.

Could we enforce via a test that both libc.so and ld.so always have the 
same version nodes?  That'll give us future flexibility at the cost of 
the extra few bytes.

> Without the version node, a binary linked against newer glibc will start
> referencing GLIBC_2.34 in ld.so after a symbol move to ld.so.  The lazy

Would it contain a reference to ld.so though?  IIRC, the symbol/version 
checks don't care about the DSO in which they are found.  So in old 
glibc, it should resolve to pthread_key_create@GLIBC_2.34 in libc.so.6 
and in newer glibc it should resolve to pthread_key_create@GLIBC_2.34 in 
ld.so.

Siddhesh

  reply	other threads:[~2021-12-13 14:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-08  9:46 Florian Weimer
2021-12-08  9:56 ` Andreas Schwab
2021-12-08 10:06   ` Florian Weimer
2021-12-08 10:20     ` Andreas Schwab
2021-12-08 10:28       ` Florian Weimer
2021-12-08 14:06         ` H.J. Lu
2021-12-24 19:01         ` Florian Weimer
2022-01-13 17:22           ` Carlos O'Donell
2022-01-13 17:32           ` Florian Weimer
2021-12-08 16:59 ` Siddhesh Poyarekar
2021-12-13 12:15   ` Florian Weimer
2021-12-13 14:54     ` Siddhesh Poyarekar [this message]
2022-01-13 17:56       ` Carlos O'Donell
2022-01-13 18:00 ` Carlos O'Donell
2022-01-22 16:08 ` H.J. Lu
2022-01-24 14:31   ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6af259d3-1123-5b5a-fe2b-7207d48e46af@gotplt.org \
    --to=siddhesh@gotplt.org \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).