Monday Patch Queue Review update (2022-05-02)

Monday Patch Queue Review update (2022-05-02)

[Carlos O'Donell]

Late update. Missed sending it out last week.

Most recent meeting status is always here:
https://sourceware.org/glibc/wiki/PatchworkReviewMeetings#Update

Meeting: 2022-05-02 @ 0900h EST5EDT

Video/Audio: https://bluejeans.com/9093064454

IRC: #glibc on OFTC.

Review new patches and restart review at the top.

 * 259 patches in NEW/NOBODY.
 * 53383 powerpc32: Remove unused HAVE_PPC_SECURE_PLT (Fangrui)
   * Reviewed by Florian.
 * 53379 elf: Remove fallback to the start of DT_STRTAB for dladdr (Fangrui)
   * Needs review.
 * 53375 elf: Simplify version test when searching a versioned symbol (Fangrui)
   * Needs review.
 * Simplify ELF_RTYPE_CLASS_EXTERN_PROTECTED_DATA and revert aarch64/arm's extern protected data handl…
   * Ask HJ if he can provide review (worked on this before).
 * elf: Remove one-default-version check when searching an unversioned symbol (Fangrui)
   * Needs review.
 * S390: Enable static PIE (Stefan Liebler)
   * Needs quite a bit of kernel support.
   * Florian and Adhemerval in agreement that we should handle failures gracefully.
   * brk failures default back to mmap.
   * Should we just use mmap unconditionally?
 * time: Use __nonnull to avoid null pointer (Xiaoming)
   * Under review from Siddhesh.
   * Fails CI/CD for 32-bit build.
 * [v4,1/6] elf: Refactor dl_new_hash so it can be tested / benchmarked (Noah)
   * Needs review for performance and timing.
   * Open question about timing from Alexander Monakov:
     * https://sourceware.org/pipermail/libc-alpha/2022-April/138275.html
 * [v2] Fix deadlock when pthread_atfork handler calls pthread_atfork or dlclose (Arjun)
   * Asking Adhemerval for review since he worked on the first patch.
 * Optimize struct pthread size (Adhemerval)
   * Two patches. Carlos to review.
 * Add arc4random support (Adhemerval)
   * Currently at v4.
   * Siddhesh raised questions about FIPS compliance.
     * Crypto stuff we add does not get exposed publicly as API.
     * No ChaCha20 API exposed then we should be OK.
     * Document in manual that arc4random is not intended for use in secure contexts.
     * Say "Not intended for cryptographic or security purposes."
   * v5 with manual change.
 * 53091 libio: Remove _IO_adjust_column, _IO_adjust_wcolumn, column tracking
   * Review after "vfprintf rework to remove vtables"
 * Stopped at 53091.
 * Sunil: Raised issues about backporting to release/2.32/master.
   * Problems caused by the AMD patch backport.
   * Florian: Could revert the AMD backport and then layer everything properly.
   * Consensus to revert the AMD patch, and then layer the commits correctly.
   * Florian: Can push revert to a branch for 2.32.
 * Florian: Would like to backport the dlinfo fixes.
   * Carlos: Only requires the addition of a header constant. OK with me.
 * Remove kernel version and distinguish library check (Adhemerval)
   * Florian to review later this week.
 * linux: Use /sys/devices/system/cpu on __get_nprocs_conf (BZ#28991)
   * Needs a follow-on fix because of rseq.
   * Carlos: Is malloc affected?
   * Adhemerval: No, only the exported symbol is impacted.

-- 
Cheers,
Carlos.