Re: [PATCH v2] iconvconfig: Fix multiple issues

[Siddhesh Poyarekar <siddhesh@sourceware.org>]

On 6/25/21 2:35 PM, Florian Weimer via Libc-alpha wrote:
> * Siddhesh Poyarekar:
> 
>> @@ -519,11 +520,12 @@ module_compare (const void *p1, const void *p2)
>>   /* Create new module record.  */
>>   static void
>>   new_module (const char *fromname, size_t fromlen, const char *toname,
>> -	    size_t tolen, const char *directory,
>> +	    size_t tolen, const char *dir_in,
>>   	    const char *filename, size_t filelen, int cost, size_t need_ext)
>>   {
>>     struct module *new_module;
>> -  size_t dirlen = strlen (directory) + 1;
>> +  size_t dirlen = strlen (dir_in) + 1;
>> +  const char *directory = xstrdup (dir_in);
> 
> Sorry, why is this copy needed?

That's the fulldir reference that goes from here into the symtab and so 
on.  Later once the handle_dir function returns and the cache file is 
being written out, this pointer is referenced and by then it has already 
been freed.

Siddhesh