From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>,
libc-alpha@sourceware.org,
Noah Goldstein <goldstein.w.n@gmail.com>
Subject: Re: [PATCH v9 03/22] Add string vectorized find and detection functions
Date: Wed, 18 Jan 2023 09:42:38 -0300 [thread overview]
Message-ID: <72f3c219-cec1-b1ff-48e1-580b4f960070@linaro.org> (raw)
In-Reply-To: <c839083b-935c-e9cc-a1b5-ea7fb9a33066@linaro.org>
On 17/01/23 22:54, Richard Henderson wrote:
> On 1/17/23 09:59, Adhemerval Zanella wrote:
>> +/* Mask off the bits defined the the S alignment value. */
>> +static __always_inline find_t
>> +shift_find_last (find_t word, uintptr_t s)
>> +{
>> + s = s % sizeof (op_t);
>> + if (__BYTE_ORDER == __LITTLE_ENDIAN)
>> + return word & ~(((op_t)-1) << (s * CHAR_BIT));
>> + else
>> + return word & ~(((op_t)-1) >> (s * CHAR_BIT));
>> +}
>
> Isn't this wrong for s % sizeof == 0?
Yes, but on strrchr I called it only for s != 0. Not sure which is the best
option here.
next prev parent reply other threads:[~2023-01-18 12:42 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 19:59 [PATCH v9 00/22] Improve generic string routines Adhemerval Zanella
2023-01-17 19:59 ` [PATCH v9 01/22] Parameterize op_t from memcopy.h Adhemerval Zanella
2023-01-17 19:59 ` [PATCH v9 02/22] Parameterize OP_T_THRES " Adhemerval Zanella
2023-01-17 19:59 ` [PATCH v9 03/22] Add string vectorized find and detection functions Adhemerval Zanella
2023-01-18 1:35 ` Richard Henderson
2023-01-18 1:54 ` Richard Henderson
2023-01-18 12:42 ` Adhemerval Zanella Netto [this message]
2023-01-18 19:24 ` Richard Henderson
2023-01-18 19:38 ` Adhemerval Zanella Netto
2023-01-17 19:59 ` [PATCH v9 04/22] string: Improve generic strlen Adhemerval Zanella
2023-01-17 19:59 ` [PATCH v9 05/22] string: Improve generic strnlen Adhemerval Zanella
2023-01-17 19:59 ` [PATCH v9 06/22] string: Improve generic strchr Adhemerval Zanella
2023-01-18 1:42 ` Richard Henderson
2023-01-17 19:59 ` [PATCH v9 07/22] string: Improve generic strchrnul Adhemerval Zanella
2023-01-17 20:00 ` [PATCH v9 08/22] string: Improve generic strcmp Adhemerval Zanella
2023-01-17 20:00 ` [PATCH v9 09/22] string: Improve generic memchr Adhemerval Zanella
2023-01-17 20:00 ` [PATCH v9 10/22] string: Improve generic memrchr Adhemerval Zanella
2023-01-18 2:10 ` Richard Henderson
2023-01-17 20:00 ` [PATCH v9 11/22] hppa: Add memcopy.h Adhemerval Zanella
2023-01-17 20:00 ` [PATCH v9 12/22] hppa: Add string-fzb.h and string-fzi.h Adhemerval Zanella
2023-01-17 20:00 ` [PATCH v9 13/22] alpha: " Adhemerval Zanella
2023-01-18 1:58 ` Richard Henderson
2023-01-17 20:00 ` [PATCH v9 14/22] arm: Add string-fza.h Adhemerval Zanella
2023-01-17 20:00 ` [PATCH v9 15/22] powerpc: " Adhemerval Zanella
2023-01-17 20:00 ` [PATCH v9 16/22] sh: Add string-fzb.h Adhemerval Zanella
2023-01-17 20:00 ` [PATCH v9 17/22] string: Hook up the default implementation on test-strlen Adhemerval Zanella
2023-01-17 20:00 ` [PATCH v9 18/22] string: Hook up the default implementation on test-strnlen Adhemerval Zanella
2023-01-17 20:00 ` [PATCH v9 19/22] string: Hook up the default implementation on test-strchr Adhemerval Zanella
2023-01-17 20:00 ` [PATCH v9 20/22] string: Hook up the default implementation on test-strcmp Adhemerval Zanella
2023-01-17 20:00 ` [PATCH v9 21/22] string: Hook up the default implementation on test-memchr Adhemerval Zanella
2023-01-17 20:00 ` [PATCH v9 22/22] string: Hook up the default implementation on test-memrchr Adhemerval Zanella
2023-01-18 18:51 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72f3c219-cec1-b1ff-48e1-580b4f960070@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).