From: Carlos O'Donell <carlos@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
libc-alpha@sourceware.org,
Richard Henderson <richard.henderson@linaro.org>,
Noah Goldstein <goldstein.w.n@gmail.com>
Subject: Re: [PATCH v9 22/22] string: Hook up the default implementation on test-memrchr
Date: Wed, 18 Jan 2023 13:51:19 -0500 [thread overview]
Message-ID: <f87c2e88-5f4b-5efe-2b0c-52056db659e8@redhat.com> (raw)
In-Reply-To: <20230117200014.1299923-23-adhemerval.zanella@linaro.org>
On 1/17/23 15:00, Adhemerval Zanella via Libc-alpha wrote:
> ---
> string/test-memrchr.c | 7 +++++++
> 1 file changed, 7 insertions(+)
Fails i686 CI.
https://patchwork.sourceware.org/project/glibc/patch/20230117200014.1299923-23-adhemerval.zanella@linaro.org/
> diff --git a/string/test-memrchr.c b/string/test-memrchr.c
> index a4eac3592e..e4cba1878a 100644
> --- a/string/test-memrchr.c
> +++ b/string/test-memrchr.c
> @@ -24,6 +24,13 @@ typedef char *(*proto_t) (const char *, int, size_t);
>
> IMPL (memrchr, 1)
>
> +/* Also check the generic implementation. */
> +#undef weak_alias
> +#define weak_alias(a, b)
> +#define MEMRCHR __memrchr_default
> +#include "string/memrchr.c"
> +IMPL (__memrchr_default, 1)
> +
> /* Naive implementation to verify results. */
> char *
> simple_memrchr (const char *s, int c, size_t n)
--
Cheers,
Carlos.
prev parent reply other threads:[~2023-01-18 18:51 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 19:59 [PATCH v9 00/22] Improve generic string routines Adhemerval Zanella
2023-01-17 19:59 ` [PATCH v9 01/22] Parameterize op_t from memcopy.h Adhemerval Zanella
2023-01-17 19:59 ` [PATCH v9 02/22] Parameterize OP_T_THRES " Adhemerval Zanella
2023-01-17 19:59 ` [PATCH v9 03/22] Add string vectorized find and detection functions Adhemerval Zanella
2023-01-18 1:35 ` Richard Henderson
2023-01-18 1:54 ` Richard Henderson
2023-01-18 12:42 ` Adhemerval Zanella Netto
2023-01-18 19:24 ` Richard Henderson
2023-01-18 19:38 ` Adhemerval Zanella Netto
2023-01-17 19:59 ` [PATCH v9 04/22] string: Improve generic strlen Adhemerval Zanella
2023-01-17 19:59 ` [PATCH v9 05/22] string: Improve generic strnlen Adhemerval Zanella
2023-01-17 19:59 ` [PATCH v9 06/22] string: Improve generic strchr Adhemerval Zanella
2023-01-18 1:42 ` Richard Henderson
2023-01-17 19:59 ` [PATCH v9 07/22] string: Improve generic strchrnul Adhemerval Zanella
2023-01-17 20:00 ` [PATCH v9 08/22] string: Improve generic strcmp Adhemerval Zanella
2023-01-17 20:00 ` [PATCH v9 09/22] string: Improve generic memchr Adhemerval Zanella
2023-01-17 20:00 ` [PATCH v9 10/22] string: Improve generic memrchr Adhemerval Zanella
2023-01-18 2:10 ` Richard Henderson
2023-01-17 20:00 ` [PATCH v9 11/22] hppa: Add memcopy.h Adhemerval Zanella
2023-01-17 20:00 ` [PATCH v9 12/22] hppa: Add string-fzb.h and string-fzi.h Adhemerval Zanella
2023-01-17 20:00 ` [PATCH v9 13/22] alpha: " Adhemerval Zanella
2023-01-18 1:58 ` Richard Henderson
2023-01-17 20:00 ` [PATCH v9 14/22] arm: Add string-fza.h Adhemerval Zanella
2023-01-17 20:00 ` [PATCH v9 15/22] powerpc: " Adhemerval Zanella
2023-01-17 20:00 ` [PATCH v9 16/22] sh: Add string-fzb.h Adhemerval Zanella
2023-01-17 20:00 ` [PATCH v9 17/22] string: Hook up the default implementation on test-strlen Adhemerval Zanella
2023-01-17 20:00 ` [PATCH v9 18/22] string: Hook up the default implementation on test-strnlen Adhemerval Zanella
2023-01-17 20:00 ` [PATCH v9 19/22] string: Hook up the default implementation on test-strchr Adhemerval Zanella
2023-01-17 20:00 ` [PATCH v9 20/22] string: Hook up the default implementation on test-strcmp Adhemerval Zanella
2023-01-17 20:00 ` [PATCH v9 21/22] string: Hook up the default implementation on test-memchr Adhemerval Zanella
2023-01-17 20:00 ` [PATCH v9 22/22] string: Hook up the default implementation on test-memrchr Adhemerval Zanella
2023-01-18 18:51 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f87c2e88-5f4b-5efe-2b0c-52056db659e8@redhat.com \
--to=carlos@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).