From: Carlos O'Donell <carlos@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Fix i486 builds with gcc 5.3
Date: Fri, 28 Oct 2016 02:23:00 -0000 [thread overview]
Message-ID: <730c76eb-c0eb-008f-a4ee-b540e392bbd5@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1610272028270.22353@digraph.polyomino.org.uk>
On 10/27/2016 04:30 PM, Joseph Myers wrote:
> On Thu, 27 Oct 2016, Carlos O'Donell wrote:
>
>> I have specifically chosen to narrow down the warning suppression to
>> gcc 5.3 because I'm not sure exactly how wide-spread the warnings is and
>> I'd rather be conservative. Others who run into the same error can expand
>> the case to gcc 5 if we see a pattern of failures.
>
> The version number in DIAG_IGNORE_NEEDS_COMMENT is not a restriction on
> where the warning is suppressed, it's for documentation purposes only, the
> most recent version known to need the suppression (so any such calls
> naming a version older than the oldest now supported for building glibc
> are appropriate for review to see if they are still needed).
Thanks. I mis-remembered that we did something with that number.
I'm going to drop this patch in favour of another one that actually fixes
all the issues compiling with -Os (unrelated to i486).
--
Cheers,
Carlos.
prev parent reply other threads:[~2016-10-28 2:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 20:25 Carlos O'Donell
2016-10-27 20:30 ` Joseph Myers
2016-10-28 2:23 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=730c76eb-c0eb-008f-a4ee-b540e392bbd5@redhat.com \
--to=carlos@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).