Re: [PATCH] Remove --disable-experimental-malloc option

[Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>]

On 28/03/23 16:41, DJ Delorie wrote:
> Adhemerval Zanella <adhemerval.zanella@linaro.org> writes:
>> -'--disable-experimental-malloc'
>> -     By default, a per-thread cache is enabled in 'malloc'.  While this
>> -     cache can be disabled on a per-application basis using tunables
>> -     (set glibc.malloc.tcache_count to zero), this option can be used to
>> -     remove it from the build completely.
>> -
> 
> Ok.  Also, yay :-)
> 
>>  CPPFLAGS-malloc-debug.c += -DUSE_TCACHE=0
>> -ifeq ($(experimental-malloc),yes)
>>  CPPFLAGS-malloc.c += -DUSE_TCACHE=1
>> -else
>> -CPPFLAGS-malloc.c += -DUSE_TCACHE=0
>> -endif
> 
> In the future, we could default this inside malloc.c instead of doing
> this in the Makefile, but it's not important now.  Ok.
> 
>> diff --git a/manual/install.texi b/manual/install.texi
>> index 260f8a5c82..cb76fbd28f 100644
>> --- a/manual/install.texi
>> +++ b/manual/install.texi
>> @@ -292,12 +292,6 @@ This option is for hackers and distributions experimenting with
>>  independently-maintained implementations of libcrypt.  It may become
>>  the default in a future release.
>>  
>> -@item --disable-experimental-malloc
>> -By default, a per-thread cache is enabled in @code{malloc}.  While
>> -this cache can be disabled on a per-application basis using tunables
>> -(set glibc.malloc.tcache_count to zero), this option can be used to
>> -remove it from the build completely.
>> -
> 
> LGTM.
> Reviewed-by: DJ Delorie <dj@redhat.com>
> 

Thanks, I will add a NEW entry on deprecated and removed features:

* The --disable-experimental-malloc is no longer available.  The per-thread
  cache can still be disable per-application using tunables
  (glibc.malloc.tcache_count set to zero).