From: Carlos O'Donell <carlos@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>, libc-alpha@sourceware.org
Subject: Re: Remove MAP_VARIABLE from hppa bits/mman.h
Date: Fri, 2 Jun 2023 22:02:32 -0400 [thread overview]
Message-ID: <79b2a685-1efc-be61-c8db-4f19531b38e6@redhat.com> (raw)
In-Reply-To: <6e50c64-98e6-7cbf-52be-c0167eb2dd9@codesourcery.com>
On 5/17/23 16:38, Joseph Myers wrote:
> As suggested in
> <https://sourceware.org/pipermail/libc-alpha/2023-February/145890.html>,
> remove the MAP_VARIABLE define from the hppa bits/mman.h, for
> consistency with Linux 6.2 which removed the define there.
>
> Tested with build-many-glibcs.py for hppa-linux-gnu.
>
> diff --git a/sysdeps/unix/sysv/linux/hppa/bits/mman.h b/sysdeps/unix/sysv/linux/hppa/bits/mman.h
> index f5a69693af..651b7dcb72 100644
> --- a/sysdeps/unix/sysv/linux/hppa/bits/mman.h
> +++ b/sysdeps/unix/sysv/linux/hppa/bits/mman.h
> @@ -24,7 +24,6 @@
>
> /* Other flags. */
> #define __MAP_ANONYMOUS 0x10 /* Don't use a file */
> -#define MAP_VARIABLE 0
>
> /* These are Linux-specific. */
> #define MAP_DENYWRITE 0x0800 /* ETXTBSY */
>
LGTM.
Reviewed Linux at commit 933174ae28ba72ab8de5b35cb7c98fc211235096 (6.4.0-rc3)
and there is no more references to MAP_VARIABLE.
The references are removed as of 71bdea6f798b425bc0003780b13e3fdecb16a010 and
are no longer in the UAPI mman.h headers.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
--
Cheers,
Carlos.
prev parent reply other threads:[~2023-06-03 2:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 20:38 Joseph Myers
2023-05-25 21:34 ` Ping " Joseph Myers
2023-06-02 22:11 ` Ping^2 " Joseph Myers
2023-06-03 2:02 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79b2a685-1efc-be61-c8db-4f19531b38e6@redhat.com \
--to=carlos@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).