From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Alejandro Colomar <colomar.6.4.3@gmail.com>
Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org,
libc-alpha@sourceware.org,
"G. Branden Robinson" <g.branden.robinson@gmail.com>
Subject: Re: [PATCH 1/3] system_data_types.7: ffix
Date: Mon, 28 Sep 2020 07:59:14 +0200 [thread overview]
Message-ID: <836b6d7d-4433-18d0-78aa-542c419c02f2@gmail.com> (raw)
In-Reply-To: <20200927211345.20433-1-colomar.6.4.3@gmail.com>
Hi Alex,
On 9/27/20 11:13 PM, Alejandro Colomar wrote:
> Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>
I do think this requires an explanation saying what you are
trying to do with this change (and then perhaps a more expansive
"Subject" also).
I can visually see what you are doing with this patch,
but I do wonder if there is a better way of doing it.
I've dropped Branden into CC. Perhaps he has a comment.
Thanks,
Michael
> ---
> man7/system_data_types.7 | 58 ++++++++++++++++++++--------------------
> 1 file changed, 29 insertions(+), 29 deletions(-)
>
> diff --git a/man7/system_data_types.7 b/man7/system_data_types.7
> index 361e8d411..ff0403df9 100644
> --- a/man7/system_data_types.7
> +++ b/man7/system_data_types.7
> @@ -66,7 +66,7 @@ system_data_types \- overview of system data types
> .TP
> .I aiocb
> .RS
> -.PP
> +.br
> Include:
> .IR <aio.h> .
> .PP
> @@ -101,7 +101,7 @@ See also:
> .TP
> .I div_t
> .RS
> -.PP
> +.br
> Include:
> .IR <stdlib.h> .
> .PP
> @@ -125,7 +125,7 @@ See also:
> .TP
> .I double_t
> .RS
> -.PP
> +.br
> Include:
> .IR <math.h> .
> .PP
> @@ -167,7 +167,7 @@ type in this page.
> .TP
> .I fenv_t
> .RS
> -.PP
> +.br
> Include:
> .IR <fenv.h> .
> .PP
> @@ -184,7 +184,7 @@ See also:
> .TP
> .I fexcept_t
> .RS
> -.PP
> +.br
> Include:
> .IR <fenv.h> .
> .PP
> @@ -201,7 +201,7 @@ See also:
> .TP
> .I float_t
> .RS
> -.PP
> +.br
> Include:
> .IR <math.h> .
> .PP
> @@ -243,7 +243,7 @@ type in this page.
> .TP
> .I gid_t
> .RS
> -.PP
> +.br
> Include:
> .IR <sys/types.h> ;
> or
> @@ -280,7 +280,7 @@ See also:
> .TP
> .I id_t
> .RS
> -.PP
> +.br
> Include:
> .IR <sys/types.h> ;
> or
> @@ -304,7 +304,7 @@ See also:
> .TP
> .I imaxdiv_t
> .RS
> -.PP
> +.br
> Include:
> .IR <inttypes.h> .
> .PP
> @@ -328,7 +328,7 @@ See also:
> .TP
> .I lconv
> .RS
> -.PP
> +.br
> Include:
> .IR <locale.h> .
> .PP
> @@ -377,7 +377,7 @@ See also:
> .TP
> .I ldiv_t
> .RS
> -.PP
> +.br
> Include:
> .IR <stdlib.h> .
> .PP
> @@ -401,7 +401,7 @@ See also:
> .TP
> .I lldiv_t
> .RS
> -.PP
> +.br
> Include:
> .IR <stdlib.h> .
> .PP
> @@ -425,7 +425,7 @@ See also:
> .TP
> .I pid_t
> .RS
> -.PP
> +.br
> Include
> .IR <sys/types.h> ;
> or
> @@ -481,7 +481,7 @@ See also:
> .TP
> .I ptrdiff_t
> .RS
> -.PP
> +.br
> Include:
> .IR <stddef.h> .
> .PP
> @@ -520,7 +520,7 @@ types in this page.
> .TP
> .I regmatch_t
> .RS
> -.PP
> +.br
> Include:
> .IR <regex.h> .
> .PP
> @@ -545,7 +545,7 @@ See also:
> .TP
> .I regoff_t
> .RS
> -.PP
> +.br
> Include:
> .IR <regex.h> .
> .PP
> @@ -577,7 +577,7 @@ types in this page.
> .TP
> .I sigevent
> .RS
> -.PP
> +.br
> Include:
> .IR <signal.h> ;
> or
> @@ -626,7 +626,7 @@ structure in this page.
> .TP
> .I siginfo_t
> .RS
> -.PP
> +.br
> Include:
> .IR <signal.h> ;
> or
> @@ -662,7 +662,7 @@ See also:
> .TP
> .I sigset_t
> .RS
> -.PP
> +.br
> Include:
> .IR <signal.h> ;
> or
> @@ -691,7 +691,7 @@ See also:
> .TP
> .I sigval
> .RS
> -.PP
> +.br
> Include:
> .IR <signal.h> .
> .PP
> @@ -723,7 +723,7 @@ in this page.
> .TP
> .I size_t
> .RS
> -.PP
> +.br
> Include:
> .I <stddef.h>
> or
> @@ -846,7 +846,7 @@ types in this page.
> .TP
> .I ssize_t
> .RS
> -.PP
> +.br
> Include:
> .IR <sys/types.h> ;
> or
> @@ -922,7 +922,7 @@ types in this page.
> .TP
> .I suseconds_t
> .RS
> -.PP
> +.br
> Include:
> .IR <sys/types.h> ;
> or
> @@ -949,7 +949,7 @@ structure in this page.
> .TP
> .I time_t
> .RS
> -.PP
> +.br
> Include:
> .I <sys/types.h>
> or
> @@ -992,7 +992,7 @@ See also:
> .TP
> .I timer_t
> .RS
> -.PP
> +.br
> Include:
> .IR <sys/types.h> ;
> or
> @@ -1015,7 +1015,7 @@ See also:
> .TP
> .I timespec
> .RS
> -.PP
> +.br
> Include:
> .IR <time.h> ;
> or
> @@ -1053,7 +1053,7 @@ See also:
> .TP
> .I timeval
> .RS
> -.PP
> +.br
> Include:
> .IR <sys/time.h> ;
> or
> @@ -1086,7 +1086,7 @@ See also:
> .TP
> .I uid_t
> .RS
> -.PP
> +.br
> Include:
> .IR <sys/types.h> ;
> or
> @@ -1120,7 +1120,7 @@ See also:
> .TP
> .I va_list
> .RS
> -.PP
> +.br
> Include:
> .IR <stdarg> ;
> or
>
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
next prev parent reply other threads:[~2020-09-28 5:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 21:13 Alejandro Colomar
2020-09-27 21:13 ` [PATCH 2/3] system_data_types.7: Add 'FILE' Alejandro Colomar
2020-09-28 6:04 ` Michael Kerrisk (man-pages)
2020-09-28 9:06 ` [PATCH v2 " Alejandro Colomar
2020-09-29 13:15 ` Alejandro Colomar
2020-09-29 13:35 ` Michael Kerrisk (man-pages)
2020-09-27 21:13 ` [PATCH 3/3] FILE.3: New link to system_data_types(7) Alejandro Colomar
2020-09-28 5:59 ` Michael Kerrisk (man-pages) [this message]
2020-09-28 9:03 ` [PATCH v2 1/3] system_data_types.7: ffix Alejandro Colomar
2020-09-28 10:34 ` Michael Kerrisk (man-pages)
2020-09-28 10:37 ` Alejandro Colomar
2020-09-28 11:13 ` G. Branden Robinson
2020-09-28 13:06 ` G. Branden Robinson
2020-09-28 13:44 ` Alejandro Colomar
2020-09-30 10:43 ` G. Branden Robinson
2020-09-30 21:32 ` Alejandro Colomar
2020-10-01 7:37 ` Michael Kerrisk (man-pages)
2020-10-01 7:52 ` Alejandro Colomar
2020-10-01 9:36 ` Michael Kerrisk (man-pages)
2020-09-28 10:40 ` [PATCH " G. Branden Robinson
2020-09-28 10:51 ` Alejandro Colomar
2020-09-28 12:49 ` G. Branden Robinson
-- strict thread matches above, loose matches on Subject: below --
2020-09-18 13:29 [PATCH 0/3] Document regmatch_t (and a ffix) Alejandro Colomar
2020-09-18 13:29 ` [PATCH 1/3] system_data_types.7: ffix Alejandro Colomar
2020-09-18 20:42 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=836b6d7d-4433-18d0-78aa-542c419c02f2@gmail.com \
--to=mtk.manpages@gmail.com \
--cc=colomar.6.4.3@gmail.com \
--cc=g.branden.robinson@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-man@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).