[PATCH] scripts/build-many-glibcs.py: Use https:// for sourceware.org Git clones

[PATCH] scripts/build-many-glibcs.py: Use https:// for sourceware.org Git clones

[Florian Weimer]

Tested by running a checkout with these changes.  No observed speed
difference; sourceware.org nowadays implements the Git protocol over
https://.

---
 scripts/build-many-glibcs.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py
index 98f02104a2..283e6fe738 100755
--- a/scripts/build-many-glibcs.py
+++ b/scripts/build-many-glibcs.py
@@ -854,7 +854,7 @@ class Context(object):
         """Check out the given version of the given component from version
         control.  Return a revision identifier."""
         if component == 'binutils':
-            git_url = 'git://sourceware.org/git/binutils-gdb.git'
+            git_url = 'https://sourceware.org/git/binutils-gdb.git'
             if version == 'mainline':
                 git_branch = 'master'
             else:
@@ -868,7 +868,7 @@ class Context(object):
                 branch = 'releases/gcc-%s' % version
             return self.gcc_checkout(branch, update)
         elif component == 'glibc':
-            git_url = 'git://sourceware.org/git/glibc.git'
+            git_url = 'https://sourceware.org/git/glibc.git'
             if version == 'mainline':
                 git_branch = 'master'
             else:
@@ -957,7 +957,7 @@ class Context(object):
             shutil.rmtree(self.component_srcdir('gcc'))
             update = False
         if not update:
-            self.git_checkout('gcc', 'git://gcc.gnu.org/git/gcc.git',
+            self.git_checkout('gcc', 'https://gcc.gnu.org/git/gcc.git',
                               branch, update)
         subprocess.run(['contrib/gcc_update', '--silent'],
                        cwd=self.component_srcdir('gcc'), check=True)

base-commit: d0e357ff45a75553dee3b17ed7d303bfa544f6fe

Re: [PATCH] scripts/build-many-glibcs.py: Use https:// for sourceware.org Git clones

[Adhemerval Zanella Netto]

On 30/08/22 01:00, Florian Weimer via Libc-alpha wrote:
> Tested by running a checkout with these changes.  No observed speed
> difference; sourceware.org nowadays implements the Git protocol over
> https://.

LGTM, thanks.

Reviewd

> 
> ---
>  scripts/build-many-glibcs.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py
> index 98f02104a2..283e6fe738 100755
> --- a/scripts/build-many-glibcs.py
> +++ b/scripts/build-many-glibcs.py
> @@ -854,7 +854,7 @@ class Context(object):
>          """Check out the given version of the given component from version
>          control.  Return a revision identifier."""
>          if component == 'binutils':
> -            git_url = 'git://sourceware.org/git/binutils-gdb.git'
> +            git_url = 'https://sourceware.org/git/binutils-gdb.git'
>              if version == 'mainline':
>                  git_branch = 'master'
>              else:
> @@ -868,7 +868,7 @@ class Context(object):
>                  branch = 'releases/gcc-%s' % version
>              return self.gcc_checkout(branch, update)
>          elif component == 'glibc':
> -            git_url = 'git://sourceware.org/git/glibc.git'
> +            git_url = 'https://sourceware.org/git/glibc.git'
>              if version == 'mainline':
>                  git_branch = 'master'
>              else:
> @@ -957,7 +957,7 @@ class Context(object):
>              shutil.rmtree(self.component_srcdir('gcc'))
>              update = False
>          if not update:
> -            self.git_checkout('gcc', 'git://gcc.gnu.org/git/gcc.git',
> +            self.git_checkout('gcc', 'https://gcc.gnu.org/git/gcc.git',
>                                branch, update)
>          subprocess.run(['contrib/gcc_update', '--silent'],
>                         cwd=self.component_srcdir('gcc'), check=True)
> 
> base-commit: d0e357ff45a75553dee3b17ed7d303bfa544f6fe
>