From: "Arsen Arsenović" <arsen@gentoo.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org, carlos@redhat.com, toolchain@gentoo.org
Subject: Re: [PATCH v2] elf: Add -z lazy to some more tests
Date: Tue, 07 Mar 2023 10:23:54 +0100 [thread overview]
Message-ID: <868rg8ykl4.fsf@gentoo.org> (raw)
In-Reply-To: <87bkl5q67n.fsf@oldenburg.str.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 953 bytes --]
Florian Weimer <fweimer@redhat.com> writes:
> * Arsen Arsenović:
>
>> @@ -1612,6 +1631,7 @@ $(objpfx)multiload.out: $(objpfx)testobj1.so
>> LDFLAGS-origtest = -rdynamic
>> $(objpfx)origtest.out: $(objpfx)testobj1.so
>>
>> +$(objpfx)resolvfail.out: $(objpfx)testobj1.so
>> ifeq ($(have-thread-library),yes)
>> $(objpfx)resolvfail: $(shared-thread-library)
>> endif
>
> Thsis seems unrelated? I can see why it's needed, but please mention it
> in the commit message at least?
Ah, right. I forgot about that entirely.
That test uses the testobj6, but doesn't depend on it. If running the
elf/resolvfail test before make check, it's possible to see:
FAIL: elf/resolvfail
original exit status 1
cannot load testobj1.so: testobj1.so: cannot open shared object file: No such file or directory
... which is fixed by just adding the dependency. Will split into a new
commit and re-send.
--
Arsen Arsenović
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 381 bytes --]
prev parent reply other threads:[~2023-03-07 9:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 0:32 Arsen Arsenović
2023-03-07 9:08 ` Florian Weimer
2023-03-07 9:23 ` Arsen Arsenović [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868rg8ykl4.fsf@gentoo.org \
--to=arsen@gentoo.org \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=toolchain@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).