From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v2 1/5] glibcextract.py: Add compile_c_snippet
Date: Wed, 10 Aug 2022 19:35:47 +0200 [thread overview]
Message-ID: <871qto9f2k.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20220810172447.1502169-2-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Wed, 10 Aug 2022 14:24:43 -0300")
* Adhemerval Zanella:
> It might be used on tests to check if a snippet build with the provided
> compiler and flags.
> ---
> scripts/glibcextract.py | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/scripts/glibcextract.py b/scripts/glibcextract.py
> index 43ab58ffe2..71d9ea1acc 100644
> --- a/scripts/glibcextract.py
> +++ b/scripts/glibcextract.py
> @@ -21,6 +21,7 @@ import os.path
> import re
> import subprocess
> import tempfile
> +import collections
Please keep the imports sorted.
> def compute_c_consts(sym_data, cc):
> @@ -173,3 +174,22 @@ def compare_macro_consts(source_1, source_2, cc, macro_re, exclude_re=None,
> if not allow_extra_2:
> ret = 1
> return ret
> +
> +CompileResult = collections.namedtuple("CompileResult", "returncode output")
> +
> +def compile_c_snippet(snippet, cc, extra_cc_args=""):
> + """Compile and return whether the SNIPPET can be build with CC along
> + EXTRA_CC_ARGS compiler flags. Return a CompileResult with RETURNCODE
> + being 0 for success, or the failure value and the compiler output.
> + """
> + with tempfile.TemporaryDirectory() as temp_dir:
> + c_file_name = os.path.join(temp_dir, 'test.c')
> + obj_file_name = os.path.join(temp_dir, 'test.o')
> + with open(c_file_name, 'w') as c_file:
> + c_file.write(snippet)
> + # Compilation has to be from stdin to avoid the temporary file
> + # name being written into the generated dependencies.
> + cmd = ('%s %s -c -o %s -x c - < %s' % (cc, extra_cc_args,
> + obj_file_name, c_file_name))
> + r = subprocess.run(cmd, shell=True, capture_output=True)
> + return CompileResult(r.returncode, r.stderr)
I think you can avoid shell=True and the direction if you just compile
c_file_name directly. Sorry, missed that earlier.
Thanks,
Florian
next prev parent reply other threads:[~2022-08-10 17:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 17:24 [PATCH v2 0/5] Fix sys/mount.h and kernel header tests Adhemerval Zanella
2022-08-10 17:24 ` [PATCH v2 1/5] glibcextract.py: Add compile_c_snippet Adhemerval Zanella
2022-08-10 17:35 ` Florian Weimer [this message]
2022-08-10 19:00 ` Adhemerval Zanella Netto
2022-08-10 17:38 ` Florian Weimer
2022-08-10 17:24 ` [PATCH v2 2/5] linux: Use compile_c_snippet to check linux/pidfd.h availability Adhemerval Zanella
2022-08-10 17:38 ` Florian Weimer
2022-08-10 17:24 ` [PATCH v2 3/5] linux: Mimic kernel defition for BLOCK_SIZE Adhemerval Zanella
2022-08-10 17:36 ` Florian Weimer
2022-08-10 17:24 ` [PATCH v2 4/5] linux: Use compile_c_snippet to check linux/mount.h availability Adhemerval Zanella
2022-08-10 17:36 ` Florian Weimer
2022-08-10 17:24 ` [PATCH v2 5/5] linux: Fix sys/mount.h usage with kernel headers Adhemerval Zanella
2022-08-11 21:57 ` Florian Weimer
2022-08-12 12:45 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qto9f2k.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).