public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v2 4/5] linux: Use compile_c_snippet to check linux/mount.h availability
Date: Wed, 10 Aug 2022 19:36:26 +0200	[thread overview]
Message-ID: <87wnbg80h1.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20220810172447.1502169-5-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Wed, 10 Aug 2022 14:24:46 -0300")

* Adhemerval Zanella:

> Checked on x86_64-linux-gnu.
> ---
>  sysdeps/unix/sysv/linux/tst-mount-consts.py | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/sysdeps/unix/sysv/linux/tst-mount-consts.py b/sysdeps/unix/sysv/linux/tst-mount-consts.py
> index 4fb356310b..c6307cb5c2 100755
> --- a/sysdeps/unix/sysv/linux/tst-mount-consts.py
> +++ b/sysdeps/unix/sysv/linux/tst-mount-consts.py
> @@ -33,6 +33,11 @@ def main():
>                          help='C compiler (including options) to use')
>      args = parser.parse_args()
>  
> +    if glibcextract.compile_c_snippet(
> +            '#include <linux/mount.h>',
> +            args.cc).returncode != 0:
> +        sys.exit (77)
> +
>      linux_version_headers = glibcsyscalls.linux_kernel_version(args.cc)
>      # Constants in glibc were updated to match Linux v5.19.  When glibc
>      # constants are updated this value should be updated to match the

Okay after compile_c_snippet is in.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Thanks,
Florian


  reply	other threads:[~2022-08-10 17:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-10 17:24 [PATCH v2 0/5] Fix sys/mount.h and kernel header tests Adhemerval Zanella
2022-08-10 17:24 ` [PATCH v2 1/5] glibcextract.py: Add compile_c_snippet Adhemerval Zanella
2022-08-10 17:35   ` Florian Weimer
2022-08-10 19:00     ` Adhemerval Zanella Netto
2022-08-10 17:38   ` Florian Weimer
2022-08-10 17:24 ` [PATCH v2 2/5] linux: Use compile_c_snippet to check linux/pidfd.h availability Adhemerval Zanella
2022-08-10 17:38   ` Florian Weimer
2022-08-10 17:24 ` [PATCH v2 3/5] linux: Mimic kernel defition for BLOCK_SIZE Adhemerval Zanella
2022-08-10 17:36   ` Florian Weimer
2022-08-10 17:24 ` [PATCH v2 4/5] linux: Use compile_c_snippet to check linux/mount.h availability Adhemerval Zanella
2022-08-10 17:36   ` Florian Weimer [this message]
2022-08-10 17:24 ` [PATCH v2 5/5] linux: Fix sys/mount.h usage with kernel headers Adhemerval Zanella
2022-08-11 21:57   ` Florian Weimer
2022-08-12 12:45     ` Adhemerval Zanella Netto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnbg80h1.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).