From: Tulio Magno Quites Machado Filho <tuliom@ascii.art.br>
To: Aurelien Jarno <aurelien@aurel32.net>,
Michael Hudson-Doyle <michael.hudson@canonical.com>,
libc-alpha@sourceware.org
Subject: Re: [PATCH] Fix BZ #29463 in the ibm128 implementation of y1l too
Date: Mon, 24 Oct 2022 09:24:21 -0300 [thread overview]
Message-ID: <8735bd9zpm.fsf@linux.ibm.com> (raw)
In-Reply-To: <Y1PCit4jpyaKABsJ@aurel32.net>
Aurelien Jarno <aurelien@aurel32.net> writes:
> Ping. Tulio (as powerpc machine maintainer) or Joseph (as math component
> maintainer), could you please have a look at this patch?
I apologize for taking so long to review this.
The code LGTM, but I agree with Aurelien that it needs a better commit message,
e.g.:
Avoid moving code across SET_RESTORE_ROUNDL.
Michael, do you need help in order to merge this?
Reviewed-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
--
Tulio Magno
next prev parent reply other threads:[~2022-10-24 12:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 2:05 Michael Hudson-Doyle
2022-10-09 22:09 ` Aurelien Jarno
2022-10-22 10:14 ` Aurelien Jarno
2022-10-24 12:24 ` Tulio Magno Quites Machado Filho [this message]
2022-10-24 13:15 ` Michael Hudson-Doyle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735bd9zpm.fsf@linux.ibm.com \
--to=tuliom@ascii.art.br \
--cc=aurelien@aurel32.net \
--cc=libc-alpha@sourceware.org \
--cc=michael.hudson@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).