From: Aurelien Jarno <aurelien@aurel32.net>
To: Michael Hudson-Doyle <michael.hudson@canonical.com>,
libc-alpha@sourceware.org
Subject: Re: [PATCH] Fix BZ #29463 in the ibm128 implementation of y1l too
Date: Sat, 22 Oct 2022 12:14:34 +0200 [thread overview]
Message-ID: <Y1PCit4jpyaKABsJ@aurel32.net> (raw)
In-Reply-To: <Y0NGtHGkHHd+cZXe@aurel32.net>
Ping. Tulio (as powerpc machine maintainer) or Joseph (as math component
maintainer), could you please have a look at this patch?
On 2022-10-10 00:09, Aurelien Jarno wrote:
> On 2022-08-22 14:05, Michael Hudson-Doyle via Libc-alpha wrote:
> > ---
> > sysdeps/ieee754/ldbl-128ibm/e_j1l.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/sysdeps/ieee754/ldbl-128ibm/e_j1l.c b/sysdeps/ieee754/ldbl-128ibm/e_j1l.c
> > index f85ba94466..0a5fe68342 100644
> > --- a/sysdeps/ieee754/ldbl-128ibm/e_j1l.c
> > +++ b/sysdeps/ieee754/ldbl-128ibm/e_j1l.c
> > @@ -792,10 +792,13 @@ __ieee754_y1l (long double x)
> > {
> > /* 0 <= x <= 2 */
> > SET_RESTORE_ROUNDL (FE_TONEAREST);
> > + xx = math_opt_barrier (xx);
> > + x = math_opt_barrier (x);
> > z = xx * xx;
> > p = xx * neval (z, Y0_2N, NY0_2N) / deval (z, Y0_2D, NY0_2D);
> > p = -TWOOPI / xx + p;
> > p = TWOOPI * __ieee754_logl (x) * __ieee754_j1l (x) + p;
> > + math_force_eval (p);
> > return p;
> > }
> >
>
> Tested-by: Aurelien Jarno <aurelien@aurel32.net>
> Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
>
> Small nitpick, you might want a similar commit message than for the
> ldbl-128, especially now that they will be far from another in the git
> log. Note however that for that one the issue is reproducible with GCC
> 12 even in -O2.
>
> --
> Aurelien Jarno GPG: 4096R/1DDD8C9B
> aurelien@aurel32.net http://www.aurel32.net
>
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2022-10-22 10:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 2:05 Michael Hudson-Doyle
2022-10-09 22:09 ` Aurelien Jarno
2022-10-22 10:14 ` Aurelien Jarno [this message]
2022-10-24 12:24 ` Tulio Magno Quites Machado Filho
2022-10-24 13:15 ` Michael Hudson-Doyle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1PCit4jpyaKABsJ@aurel32.net \
--to=aurelien@aurel32.net \
--cc=libc-alpha@sourceware.org \
--cc=michael.hudson@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).