From: Florian Weimer <fweimer@redhat.com>
To: Siddhesh Poyarekar <siddhesh@gotplt.org>
Cc: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH 3/3] elf: Extract glibcelf constants from <elf.h>
Date: Wed, 14 Sep 2022 12:06:08 +0200 [thread overview]
Message-ID: <8735cue0dr.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <8ffa2d36-7c2a-dc44-a226-edfe3c4314cb@gotplt.org> (Siddhesh Poyarekar's message of "Tue, 13 Sep 2022 13:34:26 -0400")
* Siddhesh Poyarekar:
> On 2022-09-05 10:37, Florian Weimer via Libc-alpha wrote:
>> * Florian Weimer via Libc-alpha:
>>
>>> +_register_elf_h(DtALTERA_NIOS2, prefix='DT_ALTERA_NIOS2_',
>>> + skip=_dt_skip, parent=Dt)
>> The prefix is non-regular here, it should be 'DT_NIOS_2_'. Fixed
>> locally.
>
> Shouldn't it be DT_NIOS2? I don't see DT_NIOS_2 anywhere.
Right, I fixed it. The existing consistency checks do not catch this
because the constant gets represented as a generic (non-NIOS2) one if
the pattern is not correct, and there is no collision for its value.
Maybe I should add a check to _register_elf_h that the pattern must
match something.
Thanks,
Florian
next prev parent reply other threads:[~2022-09-14 10:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 13:44 [PATCH 0/3] Parse <elf.h> in the glibcelf Python module Florian Weimer
2022-09-05 13:44 ` [PATCH 1/3] scripts: Extract glibcpp.py from check-obsolete-constructs.py Florian Weimer
2022-09-12 20:12 ` Siddhesh Poyarekar
2022-09-05 13:44 ` [PATCH 2/3] scripts: Enhance glibcpp to do basic macro processing Florian Weimer
2022-09-12 20:49 ` Siddhesh Poyarekar
2022-09-13 8:14 ` Florian Weimer
2022-09-05 13:44 ` [PATCH 3/3] elf: Extract glibcelf constants from <elf.h> Florian Weimer
2022-09-05 14:37 ` Florian Weimer
2022-09-13 17:34 ` Siddhesh Poyarekar
2022-09-14 10:06 ` Florian Weimer [this message]
2022-09-05 14:36 ` [PATCH 0/3] Parse <elf.h> in the glibcelf Python module Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735cue0dr.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).