From: Florian Weimer <fweimer@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: Add AGROUP from Linux 5.19 to sys/acct.h, remove Alpha version (bug 29502)
Date: Mon, 22 Aug 2022 11:08:40 +0200 [thread overview]
Message-ID: <875yik4pd3.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2208171827060.417173@digraph.polyomino.org.uk> (Joseph Myers's message of "Wed, 17 Aug 2022 18:27:35 +0000")
* Joseph Myers:
> Linux 5.19 adds a new accounting flag AGROUP; add it to the
> enumeration in sys/acct.h.
>
> This shows up that the Alpha-specific variant of this header has a
> different set of constants and struct acct, which appear to be the
> constants and structure layout from Linux 2.0. These were changed
> some time between Linux 2.0 and Linux 2.2; I see no evidence of an
> Alpha-specific layout or set of constants, but haven't checked the
> detailed Linux kernel history between those versions. Rather, it
> looks like tha Alpha-specific header was originally needed because of
> the use of types in the kernel structure (such as uid_t and gid_t)
> that had different sizes on Alpha, and when glibc was updated for
> changes to the structure and constants in the kernel
>
> 1998-10-02 Andreas Jaeger <aj@arthur.rhein-neckar.de>
>
> * sysdeps/unix/sysv/linux/sys/acct.h: Bring in sync with current
> linux 2.1 version.
>
> that simply omitted to do anything about the Alpha version.
>
> Thus, remove the Alpha version in order to get the updated definitions
> into use on Alpha, as I don't think the interfaces are actually
> different for Alpha with any kernel version supported by glibc.
>
> Tested for x86_64, and with build-many-glibcs.py for alpha-linux-gnu.
Constant matches kernel. Alpha change looks okay to me.
Reviewed-by: Florian Weimer <fweimer@redhat.com>
Thanks,
Florian
prev parent reply other threads:[~2022-08-22 9:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 18:27 Joseph Myers
2022-08-22 9:08 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yik4pd3.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).