public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] linux: Make tst-mount-consts unsupported for kernels headers older than 5.0
Date: Wed, 10 Aug 2022 11:18:07 +0200	[thread overview]
Message-ID: <875yj0fods.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20220809172215.593850-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Tue, 9 Aug 2022 14:22:15 -0300")

* Adhemerval Zanella:

> The linux/mount.h is only provided by Linux 5.0.
>
> Checked on x86_64-linux-gnu.
> ---
>  sysdeps/unix/sysv/linux/tst-mount-consts.py | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/sysdeps/unix/sysv/linux/tst-mount-consts.py b/sysdeps/unix/sysv/linux/tst-mount-consts.py
> index 4fb356310b..0f5b982430 100755
> --- a/sysdeps/unix/sysv/linux/tst-mount-consts.py
> +++ b/sysdeps/unix/sysv/linux/tst-mount-consts.py
> @@ -34,6 +34,9 @@ def main():
>      args = parser.parse_args()
>  
>      linux_version_headers = glibcsyscalls.linux_kernel_version(args.cc)
> +    # Linux started to provide mount.h with 5.0.
> +    if linux_version_headers < (5, 0):
> +        sys.exit (77)
>      # Constants in glibc were updated to match Linux v5.19.  When glibc
>      # constants are updated this value should be updated to match the
>      # released kernel version from which the constants were taken.

Should this use compile_c_snippet from the other patch?

Thanks,
Florian


  reply	other threads:[~2022-08-10  9:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-09 17:22 Adhemerval Zanella
2022-08-10  9:18 ` Florian Weimer [this message]
2022-08-10 14:52   ` Adhemerval Zanella Netto
2022-08-10 15:01     ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875yj0fods.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).